Skip to content

TopEdits: skip userId for anons in query #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agoujot merged 2 commits into from
Jan 9, 2026
Merged

TopEdits: skip userId for anons in query #608

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91da053
TopEdits: skip userid for anons
agoujot Jan 9, 2026
68b94c0
lint
agoujot Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Repository/TopEditsRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,11 @@ private function queryTopEditsPage(
}

$userId = $user->getId( $page->getProject() );
if ( $userId === null ) {
$userId = "";
} else {
$userId = "$userId AS user_id,";
}
$username = $this->getProjectsConnection( $project )->quote( $user->getUsername() );

// IP range handling.
Expand All @@ -428,7 +433,7 @@ private function queryTopEditsPage(
revs.rev_minor_edit AS minor,
revs.rev_len AS length,
(CAST(revs.rev_len AS SIGNED) - IFNULL(parentrevs.rev_len, 0)) AS length_change,
$userId AS user_id,
$userId
$username AS username,
comments.comment_text AS `comment`
$childSelect
Expand Down
Loading