fix: avoid errors when files are removed during build#2343
Open
howlettt wants to merge 1 commit intowxt-dev:mainfrom
Open
fix: avoid errors when files are removed during build#2343howlettt wants to merge 1 commit intowxt-dev:mainfrom
howlettt wants to merge 1 commit intowxt-dev:mainfrom
Conversation
❌ Deploy Preview for creative-fairy-df92c4 failed.
|
github-actions
Bot
added
the
pkg/wxt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added a try catch around the
lstatcall inprintFileListto avoid the build failing when files are deleted during the buildManual Testing
Tested a build of the new package using the
@sentry/vite-pluginwith thefilesToDeleteAfterUploadoption. You can see the new warnings & missing file sizes for the map files in the screenshot belowRelated Issue
This PR closes #1735