feat: Add warning for missing Firefox extension ID in manifest

[Sbrjt]

Overview

This PR adds a warning when the Firefox extension ID is missing from the manifest to help prevent invalid builds.

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings#description

Manual Testing

Not sure

Related Issue

None

[netlify]

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name	Link
🔨 Latest commit	fa85e8d
🔍 Latest deploy log	https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6a00c53cf259fa0008cb6e54
😎 Deploy Preview	https://deploy-preview-2293--creative-fairy-df92c4.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[pkg-pr-new]

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2293

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2293

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2293

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2293

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2293

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2293

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2293

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2293

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2293

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2293

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2293

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2293

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2293

wxt

npm i https://pkg.pr.new/wxt@2293

commit: 9d03083

[Sbrjt]

Do you think we can add some default like pkg.author.email or ${pkg.name}@${pkg.author.name}?

[smashedr]

Do you think we can add some default like pkg.author.email or ${pkg.name}@${pkg.author.name}?

This would be terrible, as it would clobber extension settings without the user knowing it.
This is how firefox determines what to link internal data to like the storage area.

Additionally, this field is not required for development, only for installing/signing/publishing.

It is also publicity visible and permanent once published. It can never be changed without deleting the extension and publishing an new one.

I would prefer publishing to fail if I have not set my permanent, public, extension ID yet, so that I can set a proper ID; vs having a random one published.

You can easily define browser specific settings in the config

...(isFirefox
  ? {
      browser_specific_settings: {
        gecko: {
          id: 'auto-auth@cssnr.com',
          strict_min_version: '128.0', // webRequest.onAuthRequired asyncBlocking
          data_collection_permissions: { required: ['none'] },
        },
        gecko_android: { strict_min_version: '128.0' }, // webRequest.onAuthRequired asyncBlocking
      },
    }
  : { minimum_chrome_version: '127' }), // chrome.action.openPopup

But I support a warning.

[PatrykKuniczak]

@smashedr Good catch, in that case we shouldn't add any default data.

Let's leave only warn

[aklinker1]

Looks good, but can we add a option to suppress this warning? For any MV2 extensions that don't care about it.

Similar to this PR: #1976

[PatrykKuniczak]

LGTM

[aklinker1]

@Sbrjt tests are failing, I have a fix, but can't push to your PR. Can you apply this patch?

diff --git a/packages/wxt/src/core/utils/__tests__/manifest.test.ts b/packages/wxt/src/core/utils/__tests__/manifest.test.ts
index a629f26d..341f767d 100644
--- a/packages/wxt/src/core/utils/__tests__/manifest.test.ts
+++ b/packages/wxt/src/core/utils/__tests__/manifest.test.ts
@@ -1671,7 +1671,6 @@ describe('Manifest Utils', () => {

         expect(actual.version).toBe('0.0.0');
         expect(actual.version_name).toBeUndefined();
-        expect(wxt.logger.warn).toBeCalledTimes(1);
         expect(wxt.logger.warn).toBeCalledWith(
           expect.stringContaining('Extension version not found'),
         );
@@ -2103,7 +2102,6 @@ describe('Manifest Utils', () => {
         const { manifest } = await generateManifest([], buildOutput);

         expect(manifest.manifest_version).toBe(expectedVersion);
-        expect(wxt.logger.warn).toBeCalledTimes(1);
         expect(wxt.logger.warn).toBeCalledWith(
           expect.stringContaining(
             '`manifest.manifest_version` config was set, but ignored',

Just delete the two lines calling expect(wxt.logger.warn).toBeCalledTimes(1).