Skip to content

docs: base icon path configuration for auto-icons#2285

Open
Sbrjt wants to merge 1 commit intowxt-dev:mainfrom
Sbrjt:patch-1
Open

docs: base icon path configuration for auto-icons#2285
Sbrjt wants to merge 1 commit intowxt-dev:mainfrom
Sbrjt:patch-1

Conversation

@Sbrjt
Copy link
Copy Markdown

@Sbrjt Sbrjt commented Apr 18, 2026

Overview

Added instructions for configuring base icon path in wxt.config.ts.

import { resolve } from 'node:path'
import { defineConfig } from 'wxt'

export default defineConfig({
  modules: ['@wxt-dev/module-react', '@wxt-dev/auto-icons'],
  autoIcons: {
    baseIconPath: resolve('public/icon.svg'),
  },
}

Manual Testing

None

Related Issue

None

Added instructions for configuring base icon path in wxt.config.ts.
@Sbrjt Sbrjt requested a review from Timeraa as a code owner April 18, 2026 17:01
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 18, 2026

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit da84791
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/69e3b8dd8e8b4e0008764cc3
😎 Deploy Preview https://deploy-preview-2285--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the pkg/auto-icons Includes changes to the `packages/auto-icons` directory label Apr 18, 2026
@Sbrjt Sbrjt changed the title Update README with base icon path configuration Update README with base icon path configuration for auto-icons Apr 18, 2026
@Sbrjt Sbrjt changed the title Update README with base icon path configuration for auto-icons docs: base icon path configuration for auto-icons Apr 18, 2026
Copy link
Copy Markdown
Collaborator

@PatrykKuniczak PatrykKuniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sbrjt
Copy link
Copy Markdown
Author

Sbrjt commented Apr 25, 2026

I'm sorry. I didn't understand.

@PatrykKuniczak
Copy link
Copy Markdown
Collaborator

@Sbrjt Sorry my bad, because that's over changes scope, and link doesn't work well, i need to tell you.

Let's merge your documentation with current from lines 45 - 55

You need to only put

  autoIcons: {
    baseIconPath: resolve('public/icon.svg'),
  },

inside line 53 and adjust description from line 32 a little, to match current docs, make it all consistent

aklinker1
aklinker1 previously approved these changes Apr 26, 2026
@aklinker1 aklinker1 dismissed their stale review April 26, 2026 20:39

I read the rest of the thread

@aklinker1
Copy link
Copy Markdown
Member

aklinker1 commented Apr 26, 2026

What @PatrykKuniczak is trying to say is we already have a section dedicated to config:

https://github.com/Sbrjt/wxt/blob/da8479181a0247131ca4fb83862a29b389a5d2d0/packages/auto-icons/README.md?plain=1#L45-L58

It doesn't list them, but it does point you to the code where you can see all the options.

But rather than adding anything, I think we should start generating an API reference for packages other than WXT and use a link to the type there instead of telling people to look at the code or provide more details in the README.

@aklinker1
Copy link
Copy Markdown
Member

Or better, we start publishing packages to JSR so it hosts the API reference. We can't publish wxt there, it's incompatible, but we can publish all the other packages there 🤔

@aklinker1
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/auto-icons Includes changes to the `packages/auto-icons` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants