docs: Make vitepress components css files more readable and simply#2272
docs: Make vitepress components css files more readable and simply#2272PatrykKuniczak wants to merge 30 commits intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2272 +/- ##
==========================================
- Coverage 79.73% 79.65% -0.08%
==========================================
Files 131 131
Lines 3804 3804
Branches 861 861
==========================================
- Hits 3033 3030 -3
- Misses 686 690 +4
+ Partials 85 84 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@aklinker1 In addiction, let's tell me if it's possible to add some props to docs config, to enforce run browser automatically on |
|
@aklinker1 Css props of main page in |
aklinker1
left a comment
There was a problem hiding this comment.
Thanks, these were good changes. Much easier to review when it's just these changes in the PR.
One change
1299230 to
53c082f
Compare
|
@aklinker1 Done 😄 |
|
You gotta stop force pushing... now I have to re-review the entire PR instead of just looking at what changed since my last comment. |
aklinker1
left a comment
There was a problem hiding this comment.
Last time I reviewed it running the docs locally, didn't notice any changes... but this time I reviewed it against the Netlify preview and saw lots of differences. Maybe I didn't run your PR or something last time 🤔
So some requested changes:
In all recordings, the left tab is the current wxt.dev site, right is from your PR on netlify.
- Blog homepage has changed significantly
- "Blog" font style (size and weight) changed - Make it look like it did before
- New dividers added - please remove them
- Padding is excessive compared to before - use the same amount of padding as before
- I prefer not having a hover background - remove it
Screencast_20260510_113951.webm
- Blog layout broken
- Header missing most formatting - make it look like it did before
- MD content not styled correctly - revert whatever change broke this
Screencast_20260510_114333.webm
- Entrypoint patterns look the same, good.
Screencast_20260510_114618.webm
- Examples
- I like your sidebar better - but can you add rounded corners to all four corners of each of the 3 filter sections?
- I also like that you got rid of the extra padding of the final paragraph in each example description.
Screencast_20260510_115132.webm
Ok, i though it's problem only when i was doing it here. |
Overview
This pull request focuses on improving the visual consistency and maintainability of the documentation site's components by refactoring and standardizing styles, updating class names, and enhancing accessibility. The changes include a major CSS overhaul to use more semantic class names and CSS variables, improved component structure, and minor accessibility improvements.
Component and Style Refactoring:
components, to use new native nesting and remove unnecessary props.Accessibility Improvements:
alttext to author avatar images inBlogLayout.vuefor better accessibility.Documentation Content:
noinspection
CssUnresolvedCustomPropertyto ignore missing reference error on IDE, for build time css vars.Manual Testing
Let's run
docs:devRelated Issue
Part of #2014