refactor: Code cleanup for storage package#2085
Merged
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aklinker1
commented
Feb 8, 2026
| } | ||
| const migrate = async () => { | ||
|
|
||
| const migrate: WxtStorageItem<any, any>['migrate'] = async () => { |
Member
Author
There was a problem hiding this comment.
TS performance change, fully typing the function instead of having to look at the implementation.
aklinker1
commented
Feb 8, 2026
Comment on lines
-383
to
+431
| if (debug === true) { | ||
| if (debug) { |
Member
Author
There was a problem hiding this comment.
Unnecessarily strict check
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
aklinker1
commented
Feb 8, 2026
Comment on lines
+564
to
+568
| throw Error(`'wxt/storage' must be loaded in a web extension environment | ||
|
|
||
| - If thrown during a build, see https://github.com/wxt-dev/wxt/issues/371 | ||
| - If thrown during tests, mock 'wxt/browser' correctly. See https://wxt.dev/guide/go-further/testing.html | ||
| `); |
Member
Author
There was a problem hiding this comment.
No need to join an array, just define the string in a readable way.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2085 +/- ##
==========================================
- Coverage 76.03% 75.93% -0.10%
==========================================
Files 113 113
Lines 3050 3050
Branches 686 686
==========================================
- Hits 2319 2316 -3
- Misses 648 650 +2
- Partials 83 84 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aklinker1
commented
Feb 8, 2026
| if (change == null) return; | ||
| if (dequal(change.newValue, change.oldValue)) return; | ||
|
|
||
| if (change == null || dequal(change.newValue, change.oldValue)) return; |
Member
Author
There was a problem hiding this comment.
Combined to a single statement.
Co-Authored-By: Patryk Kuniczak <p.kuniczak@gmail.com>
Timeraa
approved these changes
Feb 8, 2026
Contributor
|
Thanks for helping make WXT better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Broken out of #2081.
The storage code was originally very small and I tried to keep it small as it grew... So this PR adds a lot of whitespace I would normally add back to the code.
Manual Testing
CI passes