refactor: Code cleanup in analytics package#2084
Merged
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aklinker1
commented
Feb 8, 2026
Comment on lines
+16
to
+30
| const INTERACTIVE_TAGS = new Set([ | ||
| 'A', | ||
| 'BUTTON', | ||
| 'INPUT', | ||
| 'SELECT', | ||
| 'TEXTAREA', | ||
| ]); | ||
| const INTERACTIVE_ROLES = new Set([ | ||
| 'button', | ||
| 'link', | ||
| 'checkbox', | ||
| 'menuitem', | ||
| 'tab', | ||
| 'radio', | ||
| ]); |
Member
Author
There was a problem hiding this comment.
Move up next to other constant.
aklinker1
commented
Feb 8, 2026
Comment on lines
+81
to
+82
| // Don't track sessions for the background, it can be running indefinitely | ||
| // and will inflate session duration stats. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2084 +/- ##
==========================================
- Coverage 76.03% 75.83% -0.20%
==========================================
Files 113 113
Lines 3050 3050
Branches 686 686
==========================================
- Hits 2319 2313 -6
- Misses 648 652 +4
- Partials 83 85 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aklinker1
commented
Feb 8, 2026
Comment on lines
-42
to
+50
| const wxtAnalyticsCode = [ | ||
| `import { createAnalytics } from '${ | ||
| process.env.NPM | ||
| ? clientModuleId | ||
| : normalizePath(relative(wxtAnalyticsFolder, clientModuleId)) | ||
| }';`, | ||
| `import { useAppConfig } from '#imports';`, | ||
| ``, | ||
| `export const analytics = createAnalytics(useAppConfig().analytics);`, | ||
| ``, | ||
| ].join('\n'); | ||
| const wxtAnalyticsCode = `import { createAnalytics } from '${ | ||
| process.env.NPM | ||
| ? clientModuleId | ||
| : normalizePath(relative(wxtAnalyticsFolder, clientModuleId)) | ||
| }'; | ||
| import { useAppConfig } from '#imports'; | ||
|
|
||
| export const analytics = createAnalytics(useAppConfig().analytics); | ||
| `; |
Member
Author
There was a problem hiding this comment.
Remove join for performance.
Co-Authored-By: Patryk Kuniczak <p.kuniczak@gmail.com>
Contributor
|
Thanks for helping make WXT better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Broken out of #2081.
Manual Testing
CI checks pass