Skip to content

refactor: Standardize file existence checks to pathExists#2083

Merged
aklinker1 merged 2 commits intomainfrom
path-exists
Feb 8, 2026
Merged

refactor: Standardize file existence checks to pathExists#2083
aklinker1 merged 2 commits intomainfrom
path-exists

Conversation

@aklinker1
Copy link
Member

@aklinker1 aklinker1 commented Feb 8, 2026

Overview

Broken out of #2081.

exists is a generic name compared to pathExists, and I've updated other locations for checking if a file exists to match.

Manual Testing

CI checks pass

@netlify
Copy link

netlify bot commented Feb 8, 2026

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit f7dd555
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6988c84734a2ca0008eecdb2
😎 Deploy Preview https://deploy-preview-2083--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Co-Authored-By: Patryk Kuniczak <p.kuniczak@gmail.com>
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 8, 2026

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2083

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2083

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2083

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2083

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2083

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2083

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2083

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2083

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2083

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2083

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2083

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2083

wxt

npm i https://pkg.pr.new/wxt@2083

commit: f7dd555

@aklinker1 aklinker1 self-assigned this Feb 8, 2026
@aklinker1 aklinker1 marked this pull request as ready for review February 8, 2026 17:32
@aklinker1 aklinker1 requested a review from Timeraa as a code owner February 8, 2026 17:32
@aklinker1 aklinker1 changed the title chore: Standardize file existence checks to pathExists refactor: Standardize file existence checks to pathExists Feb 8, 2026
@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.83%. Comparing base (1fe0730) to head (f7dd555).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...src/core/builders/vite/plugins/resolveAppConfig.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
- Coverage   76.03%   75.83%   -0.20%     
==========================================
  Files         113      113              
  Lines        3050     3050              
  Branches      686      686              
==========================================
- Hits         2319     2313       -6     
- Misses        648      652       +4     
- Partials       83       85       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aklinker1 aklinker1 merged commit 99d558f into main Feb 8, 2026
22 checks passed
@aklinker1 aklinker1 deleted the path-exists branch February 8, 2026 21:21
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

Thanks for helping make WXT better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants