feat: enable native browser launching in WSL with GUI support#2055
feat: enable native browser launching in WSL with GUI support#2055Seismix wants to merge 7 commits intowxt-dev:mainfrom
Conversation
❌ Deploy Preview for creative-fairy-df92c4 failed.
|
The lockfile accidentally bumped tsdown from 0.18.1 to 0.18.4, which doesn't properly transpile the `using` keyword, causing build failures.
|
wxt/packages/runner/src/install.ts Line 14 in 83decf7 During development these build failures weren't happening because of a Node version mismatch between my env and the CI env. As far as I can tell, previous builds had Can I get input on this? I marked the PR as draft in the meantime. |
|
@Seismix Let's rebase in the near future because we'll have changes aroud Anyway Lines 4 to 6 in 1fe0730 I hope @aklinker1 won't have any arguments to block this change, but we'll see 😆 |
|
This has gone way beyond the amount of work I thought was required based off the issue discussion... Let's pause for a second, does If not, add support for WSL over there: https://github.com/mozilla/web-ext WXT relies on
|
|
You're right @aklinker1 ,
The work on the InvestigationThere are two upstream bugs at play:
Possible solutions
BranchesI've created branches for demonstration purposes:
What nextHow should I move forward? |
|
I like option 3 - interim solution + upstream support. |
Overview
This PR adds support for launching browsers in WSL environments with GUI capabilities (e.g. WSLg).
Changes:
Manual Testing
Prerequisites:
DISPLAY/WAYLAND_DISPLAYset)Test steps:
CONTRIBUTING.mdcd packages/wxt-demo && pnpm dev:firefox(orpnpm devfor Chrome)Expected results:
Related Issue
This PR closes #1931