Skip to content

chore: fix recognize lack of argument for scripts#2015

Merged
aklinker1 merged 6 commits intowxt-dev:mainfrom
PatrykKuniczak:fix/warnings-and-errors-of-scripts
Feb 6, 2026
Merged

chore: fix recognize lack of argument for scripts#2015
aklinker1 merged 6 commits intowxt-dev:mainfrom
PatrykKuniczak:fix/warnings-and-errors-of-scripts

Conversation

@PatrykKuniczak
Copy link
Collaborator

@PatrykKuniczak PatrykKuniczak commented Dec 21, 2025

Overview

I fixed check for no argument for scripts

if (pkg == null) 

which don't work(because if user don't type nothing undefined is return
with

if(!pkg)

which works :)

And i cleaned code a little, of unnecessary console.log()

Manual Testing

Try to use all of those scripts without argument.

@netlify
Copy link

netlify bot commented Dec 21, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 75680c3
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/698647b55437e70008de2ac6
😎 Deploy Preview https://deploy-preview-2015--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PatrykKuniczak PatrykKuniczak changed the title fix(scripts): fix void warnings of fs-extra(readFile, writeFile) fix(scripts): fix void warnings of fs-extra(readFile, writeFile) and recognizing lack of argument for scripts Dec 22, 2025
@PatrykKuniczak PatrykKuniczak force-pushed the fix/warnings-and-errors-of-scripts branch from 358bfe1 to 3be4972 Compare December 24, 2025 13:10
@PatrykKuniczak PatrykKuniczak changed the title fix(scripts): fix void warnings of fs-extra(readFile, writeFile) and recognizing lack of argument for scripts fix(scripts): fix recognize lack of argument for scripts Dec 25, 2025
@PatrykKuniczak
Copy link
Collaborator Author

Sorry for a little mess, i haven't checked rest of the code for fs-extra references, we need to fix it in another way, change fs-extra to fs/promises isn't solutions :(

@aklinker1 aklinker1 changed the title fix(scripts): fix recognize lack of argument for scripts chore(scripts): fix recognize lack of argument for scripts Feb 6, 2026
@aklinker1 aklinker1 changed the title chore(scripts): fix recognize lack of argument for scripts chore: fix recognize lack of argument for scripts Feb 6, 2026
@aklinker1
Copy link
Member

aklinker1 commented Feb 6, 2026

Use fix: ... when the PR fixes a bug in a package, use chore: ... when making a change that only effects contributors, like updating a script, or refactors that shouldn't change runtime behavior.

@PatrykKuniczak PatrykKuniczak changed the title chore: fix recognize lack of argument for scripts fix: recognizing lack of argument for scripts Feb 6, 2026
@PatrykKuniczak PatrykKuniczak changed the title fix: recognizing lack of argument for scripts chore: fix recognize lack of argument for scripts Feb 6, 2026
@PatrykKuniczak PatrykKuniczak force-pushed the fix/warnings-and-errors-of-scripts branch from 70fa9fd to b86f08f Compare February 6, 2026 19:48
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 6, 2026

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2015

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2015

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2015

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2015

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2015

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2015

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2015

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2015

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2015

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2015

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2015

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2015

wxt

npm i https://pkg.pr.new/wxt@2015

commit: 75680c3

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.13%. Comparing base (9bd7fc1) to head (75680c3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
+ Coverage   75.93%   76.13%   +0.19%     
==========================================
  Files         113      113              
  Lines        3050     3050              
  Branches      686      686              
==========================================
+ Hits         2316     2322       +6     
+ Misses        650      646       -4     
+ Partials       84       82       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PatrykKuniczak PatrykKuniczak force-pushed the fix/warnings-and-errors-of-scripts branch from 9f1d917 to 75680c3 Compare February 6, 2026 19:57
@PatrykKuniczak
Copy link
Collaborator Author

@aklinker1 Are you able to enable auto merge for repo?

@aklinker1
Copy link
Member

@aklinker1 Are you able to enable auto merge for repo?

Down to give it a go. Just enabled it.

@aklinker1 aklinker1 merged commit 00ae061 into wxt-dev:main Feb 6, 2026
18 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Thanks for helping make WXT better!

@PatrykKuniczak PatrykKuniczak deleted the fix/warnings-and-errors-of-scripts branch February 6, 2026 20:05
@PatrykKuniczak
Copy link
Collaborator Author

@aklinker1 You can also enable auto deleting branches after merge.

@aklinker1
Copy link
Member

@aklinker1 You can also enable auto deleting branches after merge.

It is. But since this is a fork, I can't delete your branch.

Now that you're a maintainer, you don't need to use a fork.

@PatrykKuniczak
Copy link
Collaborator Author

@aklinker1 Yeah your, right, i know but it can work for internal branches.

And yeah second right, i can, but those PRs was opened, when i wasn't.
I'll create maybe a couple more as forks, because it can be easier to split #2022 :)

@aklinker1
Copy link
Member

Also, auto-merge is really nice, thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants