chore: fix recognize lack of argument for scripts#2015
chore: fix recognize lack of argument for scripts#2015aklinker1 merged 6 commits intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
void warnings of fs-extra(readFile, writeFile)void warnings of fs-extra(readFile, writeFile) and recognizing lack of argument for scripts
358bfe1 to
3be4972
Compare
void warnings of fs-extra(readFile, writeFile) and recognizing lack of argument for scripts|
Sorry for a little mess, i haven't checked rest of the code for |
|
Use |
…File)" This reverts commit 00ff4fa.
70fa9fd to
b86f08f
Compare
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2015 +/- ##
==========================================
+ Coverage 75.93% 76.13% +0.19%
==========================================
Files 113 113
Lines 3050 3050
Branches 686 686
==========================================
+ Hits 2316 2322 +6
+ Misses 650 646 -4
+ Partials 84 82 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9f1d917 to
75680c3
Compare
|
@aklinker1 Are you able to enable |
Down to give it a go. Just enabled it. |
|
Thanks for helping make WXT better! |
|
@aklinker1 You can also enable auto deleting branches after merge. |
It is. But since this is a fork, I can't delete your branch. Now that you're a maintainer, you don't need to use a fork. |
|
@aklinker1 Yeah your, right, i know but it can work for internal branches. And yeah second right, i can, but those PRs was opened, when i wasn't. |
|
Also, auto-merge is really nice, thanks for the suggestion! |
Overview
I fixed check for no argument for scripts
which don't work(because if user don't type nothing
undefinedis returnwith
which works :)
And i cleaned code a little, of unnecessary console.log()
Manual Testing
Try to use all of those scripts without argument.