-
-
Notifications
You must be signed in to change notification settings - Fork 463
chore: Migrate monorepo to use Bun instead of PNPM #2009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aklinker1
wants to merge
61
commits into
main
Choose a base branch
from
bun-try-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
da311ce
chore: Migrate monorepo to use Bun instead of PNPM
aklinker1 2bc93bd
Add PNPM back to tests
aklinker1 c5b4591
Delete TODO
aklinker1 c3a88c0
Cleanup
aklinker1 72b1627
Removed wrong action arg, reverted
aklinker1 0608ecd
Use "bun install" over "bun i"
aklinker1 c486f61
Add `run` to all bun run commands
aklinker1 3c4d59e
Replace "i" with "install"
aklinker1 fbbd27f
add missing deps
aklinker1 a057083
Add coauthorin case I forget to on the PR merge...
aklinker1 939d161
Patch simple-git-hooks
aklinker1 9770b53
Fix type errors
aklinker1 9fbc17f
Attempt to fix bun setup
aklinker1 10781ab
Fix pnpm install
aklinker1 88c123a
Add missing coverage script
aklinker1 ca5b930
Add toolversions
aklinker1 80df813
Fix checks
aklinker1 68bfb1a
Add missing test coverage scripts
aklinker1 a86008b
fix checks
aklinker1 da13df4
Add more scripts
aklinker1 eb833e7
Fix netlify deploy
aklinker1 c7d882a
more scripts...
aklinker1 2093231
Cleanup
aklinker1 2d5ca12
Fix netlify error
aklinker1 a16eec2
all but 4 tests, very slowly...
aklinker1 9aa943e
Fix lockfile
aklinker1 a17ac48
Fix zip test
aklinker1 0ceedb0
Fix test
aklinker1 70c3ba7
Fix test
aklinker1 8b9dd7e
Fix netlify
aklinker1 ad87337
Upgrade `buildc` to resolve node deprecation
aklinker1 c640f53
optimize e2e tests
aklinker1 8355099
WIP
aklinker1 e454ca7
Merge branch 'main' into bun-try-2
aklinker1 09bd06a
fix bad merge of versions
aklinker1 f3fff9d
use `bun ci`
aklinker1 905afda
Fix failing tests
aklinker1 27c76ef
fix packageManager
aklinker1 8903a0e
fix failing tests
aklinker1 d2ef0af
cleanup
aklinker1 1727197
fix checks
aklinker1 927719d
cleanup fs usage
aklinker1 b57dfd6
cleanup
aklinker1 0e0a963
cleanup
aklinker1 cf08473
Upgrade buildc
aklinker1 838a6d6
debug init test
aklinker1 82fbe47
Update lockfile
aklinker1 24abd8e
Add another windows test log
aklinker1 386919b
oops
aklinker1 9268343
More logs
aklinker1 0af09ca
Try with --bun?
aklinker1 48c852d
Cleanup
aklinker1 e08c825
cleanup
aklinker1 3b67984
Ignore failing test for now
aklinker1 ca6dd94
cleanup
aklinker1 e34865c
debug netlify
aklinker1 a93349a
Add netfly config
aklinker1 a3dd520
Manually upgrade bun
aklinker1 43e7731
fix build
aklinker1 242ebcd
Don't use bun for vitepress
aklinker1 1d56ed1
Fix netlify?
aklinker1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,21 @@ | ||
| name: Basic Setup | ||
| description: Install PNPM, Node, and dependencies | ||
| description: Install Bun and dependencies | ||
|
|
||
| inputs: | ||
| install: | ||
| default: 'true' | ||
| description: Whether or not to run 'pnpm install' | ||
|
|
||
| installArgs: | ||
| default: '' | ||
| description: Additional args to append to "pnpm install" | ||
| description: Whether or not to run 'bun install' | ||
|
|
||
| runs: | ||
| using: composite | ||
|
|
||
| steps: | ||
| - name: 🛠️ Setup PNPM | ||
| uses: pnpm/action-setup@f2b2b233b538f500472c7274c7012f57857d8ce0 # v4.1.0 | ||
|
|
||
| - name: 🛠️ Setup NodeJS | ||
| uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0 | ||
| - name: 🛠️ Setup Bun | ||
| uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2 | ||
| with: | ||
| node-version: 20 | ||
| cache: pnpm | ||
| bun-version-file: '.tool-versions' | ||
|
|
||
| - name: 📦 Install Dependencies | ||
| if: ${{ inputs.install == 'true' }} | ||
| shell: bash | ||
| run: pnpm install ${{ inputs.installArgs }} | ||
| run: bun ci ${{ inputs.installArgs }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ jobs: | |
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Basic Checks | ||
| run: pnpm check | ||
| run: bun run check | ||
|
|
||
| builds: | ||
| name: Builds | ||
|
|
@@ -34,7 +34,7 @@ jobs: | |
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Build All Packages | ||
| run: pnpm buildc all | ||
| run: bun run buildc all | ||
|
|
||
| build-demo: | ||
| name: Build Demo | ||
|
|
@@ -47,11 +47,11 @@ jobs: | |
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Build | ||
| run: pnpm build:all | ||
| run: bun run build:all | ||
| working-directory: packages/wxt-demo | ||
|
|
||
| - name: ZIP | ||
| run: pnpm wxt zip | ||
| run: bun run wxt zip | ||
| working-directory: packages/wxt-demo | ||
|
|
||
| tests: | ||
|
|
@@ -73,16 +73,18 @@ jobs: | |
| - name: Setup | ||
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Setup Bun | ||
| uses: oven-sh/setup-bun@3d267786b128fe76c2f16a390aa2448b815359f3 # v2.1.2 | ||
| - name: Setup PNPM | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0 | ||
| with: | ||
| version: latest | ||
|
Comment on lines
+76
to
+79
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Install the other package managers required for tests (was just bun, now it's just pnpm) |
||
|
|
||
| - name: Run Tests | ||
| if: ${{ ! matrix.coverage }} | ||
| run: pnpm test | ||
| run: bun run test | ||
|
|
||
| - name: Run Tests (Coverage) | ||
| if: matrix.coverage | ||
| run: pnpm test:coverage --reporter=default --reporter=hanging-process | ||
| run: bun run test:coverage --reporter=default --reporter=hanging-process | ||
|
|
||
| - name: Upload Coverage | ||
| if: matrix.coverage | ||
|
|
@@ -110,7 +112,7 @@ jobs: | |
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Pack WXT package | ||
| run: pnpm pack | ||
| run: bun pm pack | ||
| working-directory: packages/wxt | ||
|
|
||
| - name: Install Dependencies | ||
|
|
@@ -122,15 +124,15 @@ jobs: | |
| working-directory: templates/${{ matrix.template }} | ||
|
|
||
| - name: Type Check Template | ||
| run: pnpm compile | ||
| run: bun run compile | ||
| if: matrix.template != 'svelte' | ||
| working-directory: templates/${{ matrix.template }} | ||
|
|
||
| - name: Type Check Template | ||
| run: pnpm check | ||
| run: bun run check | ||
| if: matrix.template == 'svelte' | ||
| working-directory: templates/${{ matrix.template }} | ||
|
|
||
| - name: Build Template | ||
| run: pnpm build | ||
| run: bun run build | ||
| working-directory: templates/${{ matrix.template }} | ||
aklinker1 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| bun 1.3.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No that we don't have to run
setup-nodeaction, there is only one version of NPM installed and we don't need to specify the whole path.