feat: allow setting alias: false to disable default aliases#1852
feat: allow setting alias: false to disable default aliases#1852aleclarson wants to merge 2 commits intowxt-dev:mainfrom
alias: false to disable default aliases#1852Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
a66539c to
004e4b1
Compare
|
I've rebased and added a test. |
| "strict": true, | ||
| "skipLibCheck": true, | ||
| "paths": { | ||
|
|
There was a problem hiding this comment.
This blank space is necessary?
There was a problem hiding this comment.
that is vitest's doing. generated snapshot
There was a problem hiding this comment.
or it might be project.serializeFile() actually
There was a problem hiding this comment.
wxt/packages/wxt/src/core/generate-wxt-dir.ts
Lines 246 to 266 in 9470d2b
There was a problem hiding this comment.
@aklinker1 Are you want to read this file, instead of redefining it, or only i'm don't understand, what do you mean? 😆
There was a problem hiding this comment.
if that will be fixed, it won't be in this PR
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1852 +/- ##
==========================================
- Coverage 75.99% 75.97% -0.02%
==========================================
Files 113 113
Lines 3049 3051 +2
Branches 686 689 +3
==========================================
+ Hits 2317 2318 +1
- Misses 648 649 +1
Partials 84 84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
@aleclarson Have you tried this by patching the changes into a real extension? I just ran the actions, you should be able to install this PR via pkg.pr.new now.
For some reason my gut is telling me WXT relies on some of these aliases internally and dev or production builds would crash, but I can't find those references in the code anymore... Maybe they were there and I've removed them naturally over time? Hmm 🤔
Once we merge this, maintainers will need to keep in mind that the default aliases will no longer always exist.
The other thing to consider is that WXT is opinionated, if you don't like it's opinions... to bad? Convention over configuration - all WXT projects use the same aliases, and other frameworks like Nuxt use them too.
Can I ask what your preferred aliases are?
|
@aklinker1 Don't mind |
I want to use my own alias patterns without interference from wxt.