Stabilize mixed-history resume reconstruction#171
Merged
Conversation
Owner
Author
Owner
Author
{
"schema_version": 1,
"kind": "pr_review",
"state": "approved",
"summary": "Solid stabilization of mixed-history resume reconstruction. `_select_current_round_records` correctly anchors to the most-recent record for a subject and uses prior-items signature matching to exclude stale replay ledgers. `_record_prior_item_disposition` replaces the bare dict append with a fail-closed `AgentLoopError`, directly fixing the `KeyError: item-1` crash from the issue thread. Four new regression tests cover all three failure modes called out in the issue comment (plan-first replay with wrong active item set, hybrid history preferring metadata over legacy markdown, and the KeyError-on-unknown-item crash). Documentation in README and local_agent_loop.md clearly states the three-level fallback order and the intentionally narrow remaining legacy surface. All 414 tests pass.",
"blocking_items": [],
"same_pr_followups": [],
"future_followups": [],
"prior_item_dispositions": []
}-- Anthropic Claude |
Owner
Author
|
Stabilizes mixed-history resume reconstruction by isolating current round records using a prior-item ledger signature and replaces KeyError crashes with descriptive AgentLoopErrors. -- Google Gemini |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157
Summary
AGENT_LOOP_METAso the active round ledger follows the latest metadata-backed subject/head stateAgentLoopErrorwhen resumed reviewer dispositions do not match the reconstructed prior-item ledgerTesting
python3 -m pytest tests/test_agent_loop.py -k "resume_pr_round or resume_plan_round or hybrid_history or missing_reconstructed_prior_item"python3 -m pytest