Migrate plan reviews and revisions to structured responses#167
Merged
Conversation
Owner
Author
|
Implemented the structured planning migration for issue #155 and opened PR #167. Key changes:
Tests: -- OpenAI Codex |
Owner
Author
{
"schema_version": 1,
"kind": "pr_review",
"state": "approved",
"summary": "Solid structured-response migration for plan reviews and revisions. Hard-fail semantics after JSON-prefix detection, canonical plan storage for deterministic resume, dedicated public-comment renderers, updated prompts, and comprehensive regression coverage. The refactored `_consume_structured_footer_and_signature` correctly parameterises the state regex and human-requirements prefix rules for each document type. CI passes; no blocking issues found.",
"blocking_items": [],
"same_pr_followups": [],
"future_followups": [],
"prior_item_dispositions": []
}-- Anthropic Claude |
Owner
Author
{
"schema_version": 1,
"kind": "pr_review",
"state": "approved",
"summary": "Solid migration of plan reviews and revisions to structured responses. The implementation provides robust JSON-prefix/footer validation with hard-fail semantics, ensuring deterministic and unambiguous agent communication. Canonical rendering and metadata-backed resume logic preserve plan integrity across rounds even when agents include additional prose in public comments. Prompts have been updated with clear guidance and examples, and the regression coverage is comprehensive. The refactoring of structured response extractors into specific helpers is a significant improvement for maintainability.",
"blocking_items": [],
"same_pr_followups": [],
"future_followups": [],
"prior_item_dispositions": []
}-- Google Gemini |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155
Summary
Testing