-
Notifications
You must be signed in to change notification settings - Fork 0
bugix: support min_calls and max_calls in expect_request! #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MvanDiemen
merged 5 commits into
main
from
rafal/fix_min_and_max_calls_for_expect_request
Jul 23, 2025
Merged
bugix: support min_calls and max_calls in expect_request! #20
MvanDiemen
merged 5 commits into
main
from
rafal/fix_min_and_max_calls_for_expect_request
Jul 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5d35ac68ab997a9da3b5f74eca58a6cd4d2102e1-PR-20Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
MvanDiemen
reviewed
Jul 23, 2025
MvanDiemen
reviewed
Jul 23, 2025
MvanDiemen
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
min_callsandmax_callsoptions forexpect_request!. These options were documented but completely ignored by the code. Max was taken fromcallsoption, min value was hardcoded to 1.The fix:
max_callsis explicitly provided: use itmin_callsis provided: usecalls(for backwards compatibility), ifcallsnot provided either, setmax_callstomin_callsvalue to avoid a clash