Implement toRomanNumerals function #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaufm
commented
Aug 14, 2021
| @@ -1,5 +1,15 @@ | |||
| function toRomanNumerals(num) { | |||
| return num; | |||
| var lookup = { M:1000,CM:900,D:500,CD:400,C:100,XC:90,L:50,XL:40,X:10,IX:9,V:5,IV:4,I:1 }; | |||
Collaborator
Author
There was a problem hiding this comment.
@wulfland, can you please help with the formatting here?
wulfland
force-pushed
the
main
branch
8 times, most recently
from
c29cd2b to
7a67512
Compare
Repository owner
deleted a comment from
kaufm
Feb 16, 2022
wulfland
approved these changes
Feb 16, 2022
| } | ||
| } | ||
| return roman; | ||
|
|
Comment on lines
+4
to
+10
| var i; | ||
| for ( i in lookup ) { | ||
| while ( num >= lookup[i] ) { | ||
| roman += i; | ||
| num -= lookup[i]; | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Suggested change
| var i; | |
| for ( i in lookup ) { | |
| while ( num >= lookup[i] ) { | |
| roman += i; | |
| num -= lookup[i]; | |
| } | |
| } | |
| var item; | |
| for ( i in lookup ) { | |
| while ( num >= lookup[item] ) { | |
| roman += item; | |
| num -= lookup[item]; | |
| } | |
| } |
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my solution for the
toRomanNumerals(num)function.