-
Notifications
You must be signed in to change notification settings - Fork 45
Display gateway build progress in the cli output #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds a real-time scrolling log display for gateway build progress by introducing a new terminal package with TTY detection and a ScrollingLogger that displays the last N lines while preserving complete logs to disk. Integrates the logger into docker build command execution. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Are we printing the full Docker logs in the terminal, or just high level steps? My view is that since this is a CLI and users already have access to detailed log files, it is better to keep the terminal output to a high level summary with progress indicators. If users want the full output, they can enable a debug or verbose mode. This keeps the default output readable and free from unnecessary noise. |
|
Yeah. I also felt the same. We won't meed this one. |
Purpose
Fix #805
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.