feat(stellar/wraith-names): multi-sig social recovery (#20)#32
Merged
truthixify merged 1 commit intoJun 1, 2026
Conversation
…l#20) Add guardian-based social recovery to the wraith-names Soroban contract. - GuardianConfig and RecoveryProposal contract types - DataKey::Guardians and DataKey::Recovery storage keys - set_guardians, propose_recovery, approve_recovery, cancel_recovery - DELAY_WINDOW of 100,000 ledgers between proposal and execution - 9 new NamesError variants - 8 tests covering all specified scenarios
|
@Dennis-Ritchie1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Nice implementation — the four entrypoints (
Thanks @Dennis-Ritchie1. |
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #20
Description:
Implements issue #20 — guardian-based social recovery for the
wraith-namesSoroban contract.Changes
New types
GuardianConfig { guardians: Vec<Address>, threshold: u32 }— stored per name underDataKey::GuardiansRecoveryProposal { new_owner, new_meta_address, proposed_at, approvals }— stored per name underDataKey::RecoveryDELAY_WINDOW = 100_000ledgers between proposal and executionNew functions
set_guardians(name, guardians, threshold)— owner-only; max 7 guardians, 1 ≤ threshold ≤ len; clears any pending proposalpropose_recovery(proposer, name, new_owner, new_meta_address)— guardian-only; creates proposal with proposer auto-added to approvalsapprove_recovery(approver, name)— guardian-only; executes recovery when threshold met AND delay elapsed, then clears guardians and proposalcancel_recovery(name)— owner-only; cancels within the delay windowNew error variants
NotOwner,NotGuardian,NoProposal,ProposalAlreadyExists,AlreadyApproved,DelayNotElapsed,ThresholdNotMet,TooManyGuardians,InvalidThresholdTests
8 tests covering all specified scenarios: happy path, insufficient approvals, delay not elapsed, cancel by owner, non-guardian rejection, double
approval, post-recovery state cleared, and
set_guardiansclearing a pending proposal.Notes
propose_recoveryandapprove_recoverytake an explicitAddressargument for the caller — required in Soroban since there is no implicitmsg.sender