Issue 152 #471
Open
Issue 152 #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
These should be refactored to use the checked() function
Member
There was a problem hiding this comment.
Awesome, thanks for using checked()!
The last thing we need here is to make sure we're not introducing any regressions - we've recently had some bugs fixed in this area of pagination, I want to make sure we're not re-breaking them.
Member
Contributor
There was a problem hiding this comment.
Did the "" get inadvertently escaped?
Member
There was a problem hiding this comment.
It is intended to be escaped, as it's displaying the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rather big commit, most is just whitespace / doc / escaping fixes. The fourth commit should resolve the issue originally reported in #152. Could do with a second pair of eyes to check there aren't unwanted side effects though.