Fix removal of trailing tab / whitespace in tabular table #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the final table output was trimmed with the intention of removing the last newline. This had an unintended side effect of removing the tab characters from empty columns in the specific case where the last row had one or more empty columns at the end of the row. This makes sure we are only removing the newline character as intended. Add a new unit test to verify this behavior as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the final table output was trimmed with the intention of removing the last newline. This had an unintended side effect of removing the tab characters from empty columns in the specific case where the last row had one or more empty columns at the end of the row. This makes sure we are only removing the newline character as intended.
Add a new unit test to verify this behavior as well.
This fixes #183