Fix --skip-update-check in admin context#508
Merged
swissspidy merged 9 commits intomainfrom Mar 9, 2026
Merged
Conversation
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix --skip-update-check in new admin context
Fix Mar 7, 2026
--skip-update-check in admin context
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WP-CLI's auto context,
pluginandthemecommands run as admin. WordPress core hookswp_update_plugins/wp_update_themestoload-plugins.php/load-themes.php, which fire insideload_admin_environment()duringwp_loaded—before command dispatch—making HTTP requests toapi.wordpress.orgregardless of--skip-update-check.Changes
extension-command.php: When--skip-update-checkis present inassoc_argsat bootstrap (before WordPress loads), register anadmin_inithook viaWP_CLI::add_wp_hook()that removes thewp_update_plugins/wp_update_themescallbacks.admin_initfires inside the admin page simulation after those callbacks are registered but beforeload-plugins.php/load-themes.phpdispatch, preventing the HTTP requests entirely.CommandWithUpgrade::_list: Addedremove_action()calls for both hooks in the--skip-update-checkbranch as a defensive cleanup.features/plugin.feature,features/theme.feature: Hardened the--skip-update-checkscenarios to assert no HTTP POST is made toapi.wordpress.org:Original prompt
--skip-update-checkin new admin context #507💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.