Skip to content

Fix wp site empty O(n) scaling: replace per-item cache ops with wp_cache_flush() #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix wp site empty O(n) scaling: replace per-item cache ops with wp_cache_flush() #601

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98f18af
Initial plan
Copilot Mar 17, 2026
d297857
Fix wp site empty scaling: replace per-item cache ops with wp_cache_f…
Copilot Mar 17, 2026
af549d4
Improve empty_taxonomies: use get_taxonomies() and bulk DELETE for _c…
Copilot Mar 17, 2026
453de4d
Potential fix for pull request finding
swissspidy Mar 17, 2026
ed1c395
Use db query after all
swissspidy Mar 18, 2026
bde696b
Potential fix for pull request finding
swissspidy Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 24 additions & 77 deletions src/Site_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use WP_CLI\CommandWithDBObject;
use WP_CLI\ExitException;
use WP_CLI\Fetchers\Site as SiteFetcher;
use WP_CLI\Iterators\Query as QueryIterator;
use WP_CLI\Iterators\Table as TableIterator;
use WP_CLI\Utils;
use WP_CLI\Formatter;
Expand Down Expand Up @@ -49,12 +48,6 @@ public function __construct() {
private function empty_comments() {
global $wpdb;

// Empty comments and comment cache
$comment_ids = $wpdb->get_col( "SELECT comment_ID FROM $wpdb->comments" );
foreach ( $comment_ids as $comment_id ) {
wp_cache_delete( $comment_id, 'comment' );
wp_cache_delete( $comment_id, 'comment_meta' );
}
$wpdb->query( "TRUNCATE TABLE $wpdb->comments" );
$wpdb->query( "TRUNCATE TABLE $wpdb->commentmeta" );
}
Expand All @@ -65,29 +58,6 @@ private function empty_comments() {
private function empty_posts() {
global $wpdb;

// Empty posts and post cache
$posts_query = "SELECT ID FROM $wpdb->posts";
$posts = new QueryIterator( $posts_query, 10000 );

$taxonomies = get_taxonomies();

while ( $posts->valid() ) {
/**
* @var object{ID: int} $post
*/
$post = $posts->current();

$post_id = $post->ID;

wp_cache_delete( $post_id, 'posts' );
wp_cache_delete( $post_id, 'post_meta' );
foreach ( $taxonomies as $taxonomy ) {
wp_cache_delete( $post_id, "{$taxonomy}_relationships" );
}
wp_cache_delete( $wpdb->blogid . '-' . $post_id, 'global-posts' );

$posts->next();
}
$wpdb->query( "TRUNCATE TABLE $wpdb->posts" );
$wpdb->query( "TRUNCATE TABLE $wpdb->postmeta" );
}
Expand All @@ -101,26 +71,25 @@ private function empty_taxonomies() {
*/
global $wpdb;

// Empty taxonomies and terms
$terms = $wpdb->get_results( "SELECT term_id, taxonomy FROM $wpdb->term_taxonomy" );
$taxonomies = [];
foreach ( (array) $terms as $term ) {
$taxonomies[] = $term->taxonomy;
wp_cache_delete( $term->term_id, $term->taxonomy );
}

$taxonomies = array_unique( $taxonomies );
$cleaned = [];
foreach ( $taxonomies as $taxonomy ) {
if ( isset( $cleaned[ $taxonomy ] ) ) {
continue;
$taxonomies = $wpdb->get_col( "SELECT DISTINCT taxonomy FROM $wpdb->term_taxonomy" );
if ( ! empty( $taxonomies ) ) {
$option_names = array_map(
static function ( $taxonomy ) {
return "{$taxonomy}_children";
},
$taxonomies
);
$placeholders = implode( ', ', array_fill( 0, count( $option_names ), '%s' ) );
// phpcs:disable WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.PreparedSQLPlaceholders.UnfinishedPrepare
// @phpstan-ignore argument.type
$query = $wpdb->prepare( 'DELETE FROM ' . $wpdb->options . ' WHERE option_name IN ( ' . $placeholders . ' )', $option_names );
// phpcs:enable WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.PreparedSQLPlaceholders.UnfinishedPrepare
if ( $query ) {
// phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared -- $query is already prepared above.
$wpdb->query( $query );
}
$cleaned[ $taxonomy ] = true;

wp_cache_delete( 'all_ids', $taxonomy );
wp_cache_delete( 'get', $taxonomy );
delete_option( "{$taxonomy}_children" );
}

$wpdb->query( "TRUNCATE TABLE $wpdb->terms" );
$wpdb->query( "TRUNCATE TABLE $wpdb->term_taxonomy" );
$wpdb->query( "TRUNCATE TABLE $wpdb->term_relationships" );
Expand All @@ -130,35 +99,11 @@ private function empty_taxonomies() {
}

/**
* Delete all links, link_category terms, and related cache.
* Delete all links by truncating the links table.
*/
private function empty_links() {
global $wpdb;

// Remove links and related cached data.
$links_query = "SELECT link_id FROM {$wpdb->links}";
$links = new QueryIterator( $links_query, 10000 );

// Remove bookmarks cache group.
wp_cache_delete( 'get_bookmarks', 'bookmark' );

while ( $links->valid() ) {
/**
* @var object{link_id: int} $link
*/
$link = $links->current();

$link_id = $link->link_id;

// Remove cache for the link.
wp_delete_object_term_relationships( $link_id, 'link_category' );
wp_cache_delete( $link_id, 'bookmark' );
clean_object_term_cache( $link_id, 'link' );

$links->next();
}

// Empty the table once link related cache and term is removed.
$wpdb->query( "TRUNCATE TABLE {$wpdb->links}" );
}

Expand Down Expand Up @@ -230,13 +175,14 @@ private function reset_options() {
}

/**
* Empties a site of its content (posts, comments, terms, and meta).
* Empties a site of its content (posts, comments, terms, links, and meta).
*
* Truncates posts, comments, and terms tables to empty a site of its
* Truncates posts, comments, terms, and links tables to empty a site of its
* content. Doesn't affect site configuration (options) or users.
*
* If running a persistent object cache, make sure to flush the cache
* after emptying the site, as the cache values will be invalid otherwise.
* Flushes the object cache after emptying the site to ensure stale data
* is not served. On a Multisite installation, this will flush the cache
* for all sites.
*
* To also empty custom database tables, you'll need to hook into command
* execution:
Expand Down Expand Up @@ -282,6 +228,7 @@ public function empty_( $args, $assoc_args ) {
$this->empty_taxonomies();
$this->insert_default_terms();
$this->reset_options();
wp_cache_flush();

if ( ! empty( $upload_message ) ) {
$upload_dir = wp_upload_dir();
Expand Down
Loading