Unconditionally use get_current_network_id#329
Open
swissspidy wants to merge 2 commits intomainfrom
Open
Conversation
The function was actually introduced in WP 4.6 and we now require 4.9
github-actions
Bot
added
command:core-multisite-install
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the update_db method in src/Core_Command.php by removing legacy compatibility logic for WordPress versions older than 4.9. The code now directly calls get_current_network_id() to determine the network ID. I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the multisite core update-db --network path by unconditionally using get_current_network_id() now that the project baseline no longer needs fallbacks for older WordPress versions.
Changes:
- Removed conditional fallback logic for determining the network ID in multisite DB updates.
- Always derive the network ID from the
--urlcontext viaget_current_network_id().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function was actually introduced in WP 4.6 and we now require 4.9