Fix CI: update whir to fix batch_size assertion on Linux aarch64#309
Open
Fix CI: update whir to fix batch_size assertion on Linux aarch64#309
Conversation
02ef727 to
71ea9f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batch_sizeunderflow inmatrix_commit::hash_rows_serial(Fix batch_size underflow in matrix_commit for small cache sizes WizardOfMenlo/whir#229)RUST_BACKTRACE=1to CI env for future debuggabilityRoot Cause
small_shaandcomplete_age_checktests panic on CI (ubuntu-24.04-arm, Linux aarch64) with:On Linux aarch64,
workload_sizefalls through to the 32KB default. Withstarting_log_inv_rate = 2(4x codeword expansion),message_sizeexceedstarget = 4096, makingtarget / message_size = 0→batch_size = 0.The whir fix (1) adds
.max(1)beforenext_multiple_ofand (2) assigns Linux aarch64 a 64KB cache size matching Graviton/Ampere L1d.