runtime hash selection with SHA256, Blake3, Keccak support#251
Merged
Conversation
Bisht13
requested changes
Jan 14, 2026
Bisht13
requested changes
Jan 16, 2026
Collaborator
|
Can we add e2e tests for all hashes which includes the prepare, prove and verify step? |
f552f33 to
febd3a0
Compare
ashpect
requested changes
Mar 2, 2026
4c7446c to
7c6f79d
Compare
5d51ed5 to
e64ac14
Compare
ashpect
requested changes
Mar 5, 2026
ashpect
approved these changes
Mar 6, 2026
Bisht13
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HashConfigenum, allowing selection between Skyscraper, SHA256, Keccak, and BLAKE3 without recompilationHashEngineAPI — standard hashes (SHA2, Keccak, Blake3) use WHIR's built-in engines; Skyscraper is registered as a custom engineTranscriptSpongeenum dispatches Fiat-Shamir sponge calls to the active hash variantChanges
HashConfigenum with serde support for runtime hash algorithm selectionTranscriptSpongeruntime-dispatch enum wrapping all four sponge implementationsSkyscraperHashEngineimplementing WHIR'sHashEnginetrait with batched SIMD leaf hashingpreparecommand to accept--hashconfigurationcargo bench --bench hash_bench) covering leaf hash, compression, Merkle layers, and sponge operationsTesting
Performance