feat: add WIP-103 proof verification to CLI#403
Open
paolodamico wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds WIP-103 proof verification to the CLI.
Note
Medium Risk
Adds a new CLI path for decoding and verifying ownership proofs (base64url+CBOR) and introduces new crypto dependencies, which could affect verification correctness and error handling. Also tweaks dev build profiles for ProveKit crates, which may change debug-time behavior.
Overview
Adds a new
walletkit proof verify-ownershipsubcommand that reads a base64url-encoded CBOROwnershipProof, parses--nonce/--subfield elements, runsverify_ownership_proof, and reports results in both human and JSON modes (exiting non-zero on failure).Updates CLI output to use TTY-aware colored
PASS/FAILlabels via new helpers inoutput.rs, and extends dependencies/build settings (addsworld-id-proof+ciborium; pins ProveKit devdebug-assertions=falseto avoid non-serialized debug-only proof fields; pulls inprovekit-verifierin the lockfile).Reviewed by Cursor Bugbot for commit 457a7e0. Bugbot is set up for automated code reviews on this repo. Configure here.