feat: wait for root pattern as well in serial#1194
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e4b141e34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| const PATTERN_START: &str = "hil_pattern_start-"; | ||
| const PATTERN_END: &str = "-hil_pattern_end"; | ||
| const SHELL_PROMPT_PATTERNS: &[&str] = &["worldcoin@id", "root@"]; |
There was a problem hiding this comment.
Adding "root@" to SHELL_PROMPT_PATTERNS makes wait_for_prompt succeed on any command output containing that substring, not just an actual shell prompt. In serial mode this can occur in normal output (for example log lines or text with root@...), so the post-command wait may return early and the code will issue echo $? while the original command is still running, producing incorrect status or interleaved input. Please match a prompt-specific token (e.g., the full Orb host prefix and/or prompt suffix) instead of a generic substring.
Useful? React with 👍 / 👎.
1 participant
on stage images we have root instead of worldcoin