Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
runs-on: ubuntu-latest
permissions:
contents: write
outputs:
version: ${{ steps.get-version.outputs.version }}
steps:
- name: Generate token
id: generate-token
Expand Down Expand Up @@ -51,6 +53,11 @@ jobs:
id-token: write
contents: read
steps:
- name: Configure RubyGems credentials
uses: rubygems/configure-rubygems-credentials@main
with:
role-to-assume: rg_oidc_akr_fn8dx45asckvmsnd2kka
Comment on lines +56 to +59
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pinning rubygems/configure-rubygems-credentials to a specific version tag instead of @main to prevent unexpected changes

Suggested change
- name: Configure RubyGems credentials
uses: rubygems/configure-rubygems-credentials@main
with:
role-to-assume: rg_oidc_akr_fn8dx45asckvmsnd2kka
- name: Configure RubyGems credentials
uses: rubygems/configure-rubygems-credentials@v1
with:
role-to-assume: rg_oidc_akr_fn8dx45asckvmsnd2kka
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 56:59

Comment:
Consider pinning `rubygems/configure-rubygems-credentials` to a specific version tag instead of `@main` to prevent unexpected changes

```suggestion
      - name: Configure RubyGems credentials
        uses: rubygems/configure-rubygems-credentials@v1
        with:
          role-to-assume: rg_oidc_akr_fn8dx45asckvmsnd2kka
```

How can I resolve this? If you propose a fix, please make it concise.


- name: Checkout
uses: actions/checkout@v6

Expand All @@ -64,6 +71,6 @@ jobs:
run: bundle exec rspec

- name: Publish to RubyGems
uses: rubygems/release-gem@v1
with:
gem-push-command: bundle exec rake build release:rubygem_push
run: |
bundle exec rake build
gem push pkg/workos-${{ needs.create-release.outputs.version }}.gem --host https://rubygems.org
Loading