fix: list_client_secrets returns raw list, not paginated response#586
Merged
gjtorikian merged 6 commits intoworkos:mainfrom Mar 9, 2026
Merged
Conversation
The API endpoint returns a plain JSON array for client secrets, not a paginated response object. Updated to match the pattern used by other raw-list endpoints (e.g. fga.batch_check, vault.list_object_versions). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The API expects redirect_uris as an array of {uri, default} objects,
not plain strings. Added RedirectUriInput TypedDict and updated
create_application/update_application signatures to match.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR corrects Key changes:
Confidence Score: 5/5
|
The list_client_secrets endpoint no longer uses pagination, so this filter class is dead code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use TypedDict inheritance pattern (Python 3.8+ compatible) so that uri is a required key while default remains optional. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gjtorikian
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API endpoint returns a plain JSON array for client secrets, not a paginated response object. Updated to match the pattern used by other raw-list endpoints (e.g. fga.batch_check, vault.list_object_versions).
Apologies, got this one wrong in my last MR. Interactively tested that this works.
Description
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.