Skip to content

fix: argument forwarding in vault.listObjects #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodobre wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: argument forwarding in vault.listObjects #1517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/vault/vault.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,18 @@ export class Vault {
options?: PaginationOptions | undefined,
): Promise<List<ObjectDigest>> {
const url = new URL('/vault/v1/kv', this.workos.baseURL);
if (options?.before) {
url.searchParams.set('before', options.before);
}
if (options?.after) {
url.searchParams.set('after', options.after);
}
if (options?.limit) {
url.searchParams.set('limit', options.limit.toString());
}
if (options?.order) {
url.searchParams.set('order', options.order);
}
Comment on lines +88 to +99
Copy link
Contributor

@greptile-apps greptile-apps bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test coverage for new parameters

The existing listObjects test suite only covers the no-options case. The newly forwarded before and order parameters have no corresponding test cases to verify they are correctly appended as query parameters. Consider adding tests similar to:

it('forwards before and order query parameters', async () => {
  fetchOnce({ data: [], list_metadata: { after: null, before: null } });
  await workos.vault.listObjects({ before: 'cursor123', order: 'asc' });
  expect(fetchURL()).toContain('before=cursor123');
  expect(fetchURL()).toContain('order=asc');
});


const { data } = await this.workos.get<ListResponse<ObjectDigestResponse>>(
url.toString(),
Expand Down
Loading