Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/runtime-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
node-version: 22
- uses: denoland/setup-deno@v2
with:
deno-version: v1.x
deno-version: 2.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version specification format is inconsistent with the previous version. The old version used v1.x (with 'v' prefix), but this changes to 2.x (without 'v' prefix).

While the denoland/setup-deno action likely handles both formats, it would be more consistent to use v2.x to match the previous format. This ensures compatibility if the action's version parsing logic is strict about format consistency.

Suggested change
deno-version: 2.x
deno-version: v2.x

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/runtime-tests.yml
Line: 15:15

Comment:
The version specification format is inconsistent with the previous version. The old version used `v1.x` (with 'v' prefix), but this changes to `2.x` (without 'v' prefix). 

While the `denoland/setup-deno` action likely handles both formats, it would be more consistent to use `v2.x` to match the previous format. This ensures compatibility if the action's version parsing logic is strict about format consistency.

```suggestion
          deno-version: v2.x
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

- uses: oven-sh/setup-bun@v2

- name: Install and build
Expand Down