Stop dropping pending tag names from the shared selector callback#25541
Open
crazytonyli wants to merge 2 commits intotrunkfrom
Open
Stop dropping pending tag names from the shared selector callback#25541crazytonyli wants to merge 2 commits intotrunkfrom
crazytonyli wants to merge 2 commits intotrunkfrom
Conversation
The shared tag selector filtered out pending (`id == 0`) terms before notifying its parent, which silently dropped user-typed tag names if the user published before the async search/create completed. Normal posts publish tag names directly through `RemotePostCreateParameters`, and the custom-post REST flow resolves IDs at save time via `TermResolutionService.resolveIDs(for:)`, so neither consumer needs the filter. Drop it so the parent always observes the user's full selection, and replace the old test that locked in the broken contract with one that asserts the callback fires synchronously with the pending term.
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32168 | |
| Version | PR #25541 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | f67070a | |
| Installation URL | 080conoeng0co |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32168 | |
| Version | PR #25541 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | f67070a | |
| Installation URL | 5uo9802cvaoa8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/a8c/issue/CMM-2060
The first commit simply formats the Swift code. The core change is one line, in the second commit. See the code comments for the root cause.