Fix an issue where the "More Options" section content is empty#25407
Open
crazytonyli wants to merge 1 commit intotrunkfrom
Open
Fix an issue where the "More Options" section content is empty#25407crazytonyli wants to merge 1 commit intotrunkfrom
crazytonyli wants to merge 1 commit intotrunkfrom
Conversation
Collaborator
Generated by 🚫 Danger |
|
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31602 | |
| Version | PR #25407 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 478982b | |
| Installation URL | 6l8j3cvfashfg |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31602 | |
| Version | PR #25407 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 478982b | |
| Installation URL | 1s9c5b3gerfg0 |
kean
approved these changes
Mar 19, 2026
| var id: Self { self } | ||
| } | ||
|
|
||
| private var visibleMoreOptions: [MoreOption] { |
Contributor
There was a problem hiding this comment.
(nit) This code probably belong to the view model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's possible that the custom post type is configured in a way that none of the "More Options" are applicable. In that case, we should not show the section at all. At the moment, the header shows, but the content is empty.