Reader: Fix an issue with navigateToCommentID failing to find comments#25389
Open
Reader: Fix an issue with navigateToCommentID failing to find comments#25389
Conversation
Collaborator
kean
force-pushed
the
fix/scroll-to-comment-from-notifications
branch
from
2fbc7d4 to
efe3a3e
Compare
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31545 | |
| Version | PR #25389 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | cb119e7 | |
| Installation URL | 3h7ljc99agv58 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31545 | |
| Version | PR #25389 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | cb119e7 | |
| Installation URL | 79877uujah0t8 |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
|
crazytonyli
reviewed
Mar 18, 2026
Contributor
crazytonyli
left a comment
crazytonyli
left a comment
There was a problem hiding this comment.
I wonder if you can load the selected comment thread first, put it on top of the screen, then load the rest of the comments? I'm not sure if there is an API to get the root-level comment.
| private var navigationOverlayView: UIView? | ||
| private var navigationPagesLoaded = 0 | ||
| private var navigationCommentID: Int32? | ||
| private var onNavigationCommentRendered: (() -> Void)? |
Contributor
There was a problem hiding this comment.
I wonder if these properties can be put into a dedicated struct, so that you can nil the struct instead of all these individual properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CMM-574: Scrolling to a selected comment fails if the comments isn't on the first page.
RCA: When you open a comment from notifications, the app loads the first page (20 comments) and attempts to find the selected comment within it. If it can't, it fails to scroll to the selected comment. In addition, due to the asynchronous nature of comment rendering, the automatic scroll is choppy.
Mitigation:
In addition, I slightly increases the width of depth indicators as they were not visible when running on a device.
Note: of course, this is not an ideal solution. In the perfect world, the app would fetch the page with a comment and let you scroll up or down to fetch more pages. AFAIK there is no API to identify what page the comments belongs to.
Recording
The recording was made on a simulator. It's a worst-case scenario because
WKWebViewrendering is significantly worse and slower on a simulator. On a device, it works much nicer.Before / After
comment-scroll-before.mov
Screen.Recording.2026-03-17.at.12.00.15.PM.mov