Stats empty view improvements #22523
Draft
+17
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove TODO comments and test block that always displayed the empty view, restoring the proper showUiModel logic. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22523-e9ea108 | |
| Commit | e9ea108 | |
| Direct Download | jetpack-prototype-build-pr22523-e9ea108.apk |
Contributor
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22523-e9ea108 | |
| Commit | e9ea108 | |
| Direct Download | wordpress-prototype-build-pr22523-e9ea108.apk |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
Updated tests to expect UiModel.Empty since mapInsights currently returns the empty state for testing. Removed image assertion since the image parameter was removed from UiModel.Empty. Also fixed minor string typo. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the stats insights empty view by removing the unused image/illustration and improving the empty state strings.
Note: This PR is marked "Do not merge" because it contains a
TODOitem about removing code that always returns empty insight stats. This is why CI is failing. It will be removed before merging.Changes:
imageparameter fromUiModel.Emptydata classStatsListFragmentstats_empty_view.xmllayoutNote: Contains a TODO in
UiModelMapperthat forces the empty view for testing purposes - remove before final merge.Testing instructions
Stats empty view testing:
Before and after