Skip to content

Fix flaky "clear removes all entries" test #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mokagio merged 8 commits into from
Mar 17, 2026
Merged

Fix flaky "clear removes all entries" test #370

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dd7ee3a
fix: deflake clear cache tests
mokagio Mar 16, 2026
3bc922d
ci: run Swift tests 50x in parallel
mokagio Mar 16, 2026
274006c
fix: use fresh cacheRoot in storeAfterClear
mokagio Mar 16, 2026
358b5be
ci: remove parallelism: 50 from Swift tests
mokagio Mar 16, 2026
389a40e
fix: poll with backoff instead of cheating
mokagio Mar 16, 2026
1dabad2
ci: remove parallelism: 50 from Swift tests
mokagio Mar 16, 2026
e090a61
ci: trigger fresh build
mokagio Mar 16, 2026
05f048d
refactor: use guard in poll loop
mokagio Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ios/Tests/GutenbergKitTests/Stores/EditorURLCacheTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ struct EditorURLCacheTests {
try cache.store(makeResponse(), for: otherURL, httpMethod: .GET)
try cache.clear()

try waitForClearToTakeEffect(cache: cache, url: testURL)

#expect(try cache.response(for: testURL, httpMethod: .GET) == nil)
#expect(try cache.response(for: otherURL, httpMethod: .GET) == nil)
}
Expand All @@ -157,11 +159,30 @@ struct EditorURLCacheTests {
func storeAfterClear() throws {
try cache.store(makeResponse(), for: testURL, httpMethod: .GET)
try cache.clear()

try waitForClearToTakeEffect(cache: cache, url: testURL)

let newResponse = makeResponse(data: Data("after clear"))
try cache.store(newResponse, for: testURL, httpMethod: .GET)
#expect(try cache.response(for: testURL, httpMethod: .GET) == newResponse)
}

/// Polls until `URLCache.removeAllCachedResponses()` has taken effect.
///
/// Uses exponential backoff (0.05s, 0.1s, 0.2s, 0.4s, ...) with a 1s total timeout.
/// `URLCache` clears asynchronously, so the in-memory layer may still serve
/// stale entries for a short window after `clear()` returns.
private func waitForClearToTakeEffect(cache: EditorURLCache, url: URL) throws {
var delay: TimeInterval = 0.05
var elapsed: TimeInterval = 0
while elapsed < 1.0 {
guard try cache.response(for: url, httpMethod: .GET) != nil else { return }
Thread.sleep(forTimeInterval: delay)
elapsed += delay
delay *= 2
}
}

// MARK: - URLs with query parameters

@Test("URLs with different query parameters are independent")
Expand Down
Loading