Skip to content

Add support for border radius #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kishannareshpal wants to merge 2 commits into from
Closed

Add support for border radius #993

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9e0714
feat(ios): support for corner radius
kishannareshpal Jan 3, 2026
ac79a13
tweak ios corner radius to use a clipping view
kishannareshpal Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions ios/RNPDFPdf/RNPDFPdfView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ @implementation RNPDFPdfView
RCTBridge *_bridge;
PDFDocument *_pdfDocument;
PDFView *_pdfView;
UIView *_pdfClipView;
PDFOutline *root;
float _fixScaleFactor;
bool _initialed;
Expand Down Expand Up @@ -212,7 +213,8 @@ - (void)updateLayoutMetrics:(const facebook::react::LayoutMetrics &)layoutMetric
{
// Fabric equivalent of `reactSetFrame` method
[super updateLayoutMetrics:layoutMetrics oldLayoutMetrics:oldLayoutMetrics];
_pdfView.frame = CGRectMake(0, 0, layoutMetrics.frame.size.width, layoutMetrics.frame.size.height);
_pdfClipView.frame = CGRectMake(0, 0, layoutMetrics.frame.size.width, layoutMetrics.frame.size.height);
_pdfView.frame = _pdfClipView.bounds;

NSMutableArray *mProps = [_changedProps mutableCopy];
if (_initialed) {
Expand All @@ -221,6 +223,11 @@ - (void)updateLayoutMetrics:(const facebook::react::LayoutMetrics &)layoutMetric
_initialed = YES;

[self didSetProps:mProps];

if (self.layer.cornerRadius > 0) {
_pdfClipView.layer.cornerRadius = self.layer.cornerRadius;
_pdfClipView.layer.masksToBounds = YES;
}
}

- (void)handleCommand:(const NSString *)commandName args:(const NSArray *)args
Expand Down Expand Up @@ -277,8 +284,12 @@ - (void)initCommonProps
_initialed = NO;
_changedProps = NULL;

[self addSubview:_pdfView];
_pdfClipView = [[UIView alloc] initWithFrame:self.bounds];
_pdfClipView.backgroundColor = [UIColor clearColor];
_pdfClipView.clipsToBounds = YES;

[self addSubview:_pdfClipView];
[_pdfClipView addSubview:_pdfView];

// register notification
NSNotificationCenter *center = [NSNotificationCenter defaultCenter];
Expand Down Expand Up @@ -537,11 +548,11 @@ - (void)didSetProps:(NSArray<NSString *> *)changedProps
}
}


- (void)reactSetFrame:(CGRect)frame
{
[super reactSetFrame:frame];
_pdfView.frame = CGRectMake(0, 0, frame.size.width, frame.size.height);
_pdfClipView.frame = CGRectMake(0, 0, frame.size.width, frame.size.height);
_pdfView.frame = _pdfClipView.bounds;

NSMutableArray *mProps = [_changedProps mutableCopy];
if (_initialed) {
Expand All @@ -550,6 +561,11 @@ - (void)reactSetFrame:(CGRect)frame
_initialed = YES;

[self didSetProps:mProps];

if (self.layer.cornerRadius > 0) {
_pdfClipView.layer.cornerRadius = self.layer.cornerRadius;
_pdfClipView.layer.masksToBounds = YES;
}
}


Expand All @@ -569,6 +585,7 @@ - (void)dealloc{

_pdfDocument = Nil;
_pdfView = Nil;
_pdfClipView = Nil;

//Remove notifications
[[NSNotificationCenter defaultCenter] removeObserver:self name:@"PDFViewDocumentChangedNotification" object:nil];
Expand Down