Skip to content

[Bug] isAllowedClient() only checks the first valid CIDR (fixes #105) #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wollomatic merged 1 commit into from
Mar 8, 2026
Merged

[Bug] isAllowedClient() only checks the first valid CIDR (fixes #105) #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/socket-proxy/handlehttprequest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ func isAllowedClient(clientIPStr string) (bool, error) {
_, allowedIPNet, err := net.ParseCIDR(allowFromItem)
if err == nil {
// AllowFrom is a valid CIDR, so check if IP address is in allowed network
return allowedIPNet.Contains(clientIP), nil
if allowedIPNet.Contains(clientIP) {
return true, nil
}
continue
}

// AllowFrom is not a valid CIDR, so try to resolve it via DNS
Expand Down