add back WOLFSSL_QT macro guard for get cipher name behavior#9997
add back WOLFSSL_QT macro guard for get cipher name behavior#9997JacobBarthelmeh wants to merge 1 commit intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Re-introduces the WOLFSSL_QT macro guard so that Qt builds use the OPENSSL_ALL-style cipher suite ordering/stack handling in wolfSSL_get_ciphers_compat().
Changes:
- Extend
OPENSSL_ALLpreprocessor checks to also includeWOLFSSL_QTfor cipher-name table access. - Apply the same
OPENSSL_ALL/Qt conditional behavior to cipher suite iteration order (priority ordering). - Apply the same
OPENSSL_ALL/Qt conditional behavior tocipher.in_stackhandling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Reintroduces the WOLFSSL_QT preprocessor guard so Qt builds use the non-IANA cipher name path, restoring behavior removed in #9831.
Changes:
- Gate
wolfSSL_CIPHER_get_name()IANA-name behavior behind!defined(WOLFSSL_QT). - Update API tests to expect IANA cipher naming only when
WOLFSSL_QTis not defined.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/api.c | Adjusts cipher-name assertions to account for WOLFSSL_QT builds using a different naming path. |
| src/ssl.c | Restores WOLFSSL_QT guard to select non-IANA cipher name behavior for Qt builds. |
Comments suppressed due to low confidence (1)
tests/api.c:1
- This
#ifline continuation/indentation is inconsistent with the earlier updated block in this file (which wraps theWOLFSSL_QTcheck onto its own aligned continuation line). For readability and to keep preprocessor conditions consistent, wrap/indent this condition the same way as the other occurrence.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
Retest this please Jenkins |
This adds back in the WOLFSSL_QT guard that was removed in #9831