[Microchip TA-100] Fix port + update to cryptoauthlib v3.6.0 by danielinux · Pull Request #9702 · wolfSSL/wolfssl

danielinux · 2026-01-22T17:00:16Z

Description

Rework of TA-100 support to match cryptoauthlib v3.6.0's API. AES-GCM now working.

Fixes zd#20640

Testing

Used wolfDemo board (STM32U585) + TA100 mikrobus module.

Test log (with verbose TA-100 interactions) attached.

test_12a16e6cc.log

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

wolfcrypt/src/port/atmel/atmel.c

wolfcrypt/src/signature.c

tests/api.c

wolfcrypt/src/port/atmel/atmel.c

wolfcrypt/src/rsa.c

wolfssl/wolfcrypt/rsa.h

wolfcrypt/test/test.c

wolfcrypt/benchmark/benchmark.c

wolfcrypt/src/port/atmel/atmel.c

dgarske · 2026-02-12T05:49:47Z

Jenkins retest this please.

configure.ac

dgarske · 2026-02-19T21:16:56Z

Jenkins retest this please

dgarske · 2026-02-20T00:15:16Z

@danielinux Please rebase and squash this. Hopefully that will resolve things.

dgarske · 2026-03-04T19:57:59Z

@tmael can you please help get this PR rebased, merge conflicts resolved and ready for merge? This work has been lingering for way too long.

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

dgarske · 2026-02-19T21:19:05Z

wolfcrypt/test/test.c

+        if (ret) {
+            goto exit_rsa;
+        }
+        ret = wc_RsaPublicEncrypt(in, inLen, out, 256, key, &rng);


Let's not duplicate these lines. Just make sure outSz = 256 and use the single call below.

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

dgarske · 2026-03-19T19:32:02Z

Jenkins retest this please

dgarske · 2026-03-19T21:19:39Z

@tmael please change build errors. Might just need to rebase and force push.

dgarske · 2026-03-19T21:20:39Z

wolfssl/wolfcrypt/rsa.h

    byte   keyIdSet;
 #endif
+#if defined(WOLFSSL_MICROCHIP_TA100)
+    uint16_t  rKeyH;        /* private key handle */


uint16_t is fine since it matches what is in cryptauthlib

dgarske · 2026-03-19T21:22:17Z

wolfcrypt/test/test.c

            plain = NULL;
            TEST_SLEEP();

+#if defined(WOLFSSL_MICROCHIP_TA100)


Should this flow be used for all cases (not just TA100)? Or maybe its good to test both API methods in non TA100 case?

I’m unsure and don’t want to introduce any side effects for non-TA100 tests.

dgarske · 2026-03-19T21:22:34Z

wolfcrypt/test/test.c

        ERROR_OUT(WC_TEST_RET_ENC_EC(ret), exit_rsa);
 #endif

+#if defined(WOLFSSL_KEY_GEN) && defined(WOLFSSL_MICROCHIP_TA100)


Again couldn't this be useful in other non TA-100 cases too?

Not useful. Non-TA100 use cases already use keys from a buffer, and we have key generation tests in other areas.

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

- Using correct slot ID for AES keys - Adjust IV length - Fallback operations to software for unsupported ECC curves (all tests passing)

ECC384 should be supported in TA-100

…e AS_IF to conditionally run the manual search fallback

…kg.m4 is unavailable

…#ifndef WOLFSSL_MICROCHIP_TA100

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Copilot AI review requested due to automatic review settings January 22, 2026 17:00

Copilot started reviewing on behalf of danielinux January 22, 2026 17:00 View session

This comment was marked as outdated.

Sign in to view

danielinux self-assigned this Jan 22, 2026

danielinux force-pushed the ta100_2025 branch 2 times, most recently from 03c4ab8 to 199c152 Compare February 10, 2026 12:54

danielinux requested a review from Copilot February 10, 2026 13:08

Copilot started reviewing on behalf of danielinux February 10, 2026 13:09 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

danielinux assigned wolfSSL-Bot and unassigned danielinux Feb 10, 2026

SparkiDev assigned danielinux Feb 11, 2026

dgarske requested a review from tmael February 12, 2026 05:49

dgarske requested changes Feb 18, 2026

View reviewed changes

configure.ac Show resolved Hide resolved

danielinux force-pushed the ta100_2025 branch from f6c5f77 to 81086ff Compare February 19, 2026 08:24

danielinux assigned tmael Feb 19, 2026

danielinux force-pushed the ta100_2025 branch from 81086ff to 36b0e21 Compare February 20, 2026 19:30

dgarske unassigned danielinux Mar 4, 2026

Copilot AI review requested due to automatic review settings March 5, 2026 01:13

tmael force-pushed the ta100_2025 branch from 36b0e21 to 97a7359 Compare March 5, 2026 01:13

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 5, 2026 23:30

tmael force-pushed the ta100_2025 branch from 97a7359 to 6289e72 Compare March 5, 2026 23:30

Copilot AI reviewed Mar 5, 2026

View reviewed changes

dgarske added the For This Release Release version 5.9.0 label Mar 6, 2026

dgarske previously approved these changes Mar 6, 2026

View reviewed changes

douzzer removed the Staged Staged for merge pending final test results and review label Mar 9, 2026

Copilot AI review requested due to automatic review settings March 11, 2026 18:39

Copilot AI reviewed Mar 11, 2026

View reviewed changes

dgarske added Not For This Release Not for release 5.9.0 and removed For This Release Release version 5.9.0 labels Mar 13, 2026

dgarske assigned tmael and unassigned tmael Mar 19, 2026

dgarske requested changes Mar 19, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 20, 2026 15:37

tmael force-pushed the ta100_2025 branch from a7ae3f2 to b61009a Compare March 20, 2026 15:37

Copilot AI reviewed Mar 20, 2026

View reviewed changes

tmael and others added 13 commits March 20, 2026 08:40

TA100: Microchip Trust Anchor support RSA/ECC

eca7215

TA100: follow-up changes (squash after 4e64cb5)

23442c6

[TA-100] Fixed GMAC, AES-GCM, AES, ECC

56f50cd

- Using correct slot ID for AES keys - Adjust IV length - Fallback operations to software for unsupported ECC curves (all tests passing)

Reverted changes to fallback ECC

e5362a3

ECC384 should be supported in TA-100

[TA-100] Fixed ECC384. Adding RSA.

e4769ad

[TA-100] Fixed RSA keygen/sign/verify, tests

db256d5

Close PKG_CHECK_MODULES with a no-op failure action and use a separat…

638ba7a

…e AS_IF to conditionally run the manual search fallback

[TA-100] Fix build/test regressions in non-TA100 builds

358e7cb

wraps PKG_CHECK_MODULES with m4_ifdef so it's silently skipped when p…

4340b11

…kg.m4 is unavailable

Removed the dead #ifdef WOLFSSL_MICROCHIP_TA100 block (it was inside …

01ece49

…#ifndef WOLFSSL_MICROCHIP_TA100

Fix formatting

5bedbff

Fix comments and shellcheck warning

1ad2b5f

Fix typo

18eb397

tmael force-pushed the ta100_2025 branch from b61009a to 18eb397 Compare March 20, 2026 15:41

Correct Nested comment for Espressif build

3ed2aa2

Copilot AI review requested due to automatic review settings March 21, 2026 00:59

Copilot AI reviewed Mar 21, 2026

View reviewed changes

Conversation

danielinux commented Jan 22, 2026

Description

Testing

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dgarske commented Feb 12, 2026

Uh oh!

Uh oh!

dgarske commented Feb 19, 2026

Uh oh!

dgarske commented Feb 20, 2026

Uh oh!

dgarske commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

dgarske Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

dgarske commented Mar 19, 2026

Uh oh!

dgarske commented Mar 19, 2026

Uh oh!

dgarske Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

tmael Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

dgarske Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

tmael Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

dgarske Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

tmael Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants