20260120-linuxkm-RHEL9v6-and-RDSEED-sanity-check #9691
+514
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NDOM_CALLBACKS-5v14-570v58v1-el9_6.patch
… to work around buggy RDSEED by disabling it if it generates three identical 64 bit words consecutively; wolfssl/wolfcrypt/settings.h: if DEBUG_WOLFSSL && !WC_NO_VERBOSE_RNG, set WC_VERBOSE_RNG, and add WOLFSSL_NO_DEBUG_CERTS to allow inhibition of WOLFSSL_DEBUG_CERTS.
Contributor
Author
|
Note, see ZD#19574 |
SparkiDev
requested changes
Jan 20, 2026
wolfcrypt/src/random.c
Outdated
| return -1; | ||
|
|
||
| if (rdseed_sanity_status == 0) { | ||
| static word64 sanity_words[2] = {0, 0}; |
Contributor
There was a problem hiding this comment.
Does it need to be static?
Contributor
Author
There was a problem hiding this comment.
changed as discussed.
…I and peer review:
* in wc_GenerateSeed_IntelRD(), use stack/register allocation for sanity_word{1,2}, and
* don't set WC_VERBOSE_RNG if WOLFSSL_DEBUG_PRINTF is missing.
Contributor
Author
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
linuxkm/patches/5.14.0-570.58.1.el9_6/WOLFSSL_LINUXKM_HAVE_GET_RANDOM_CALLBACKS-5v14-570v58v1-el9_6.patchwolfcrypt/src/random.c: add sanity check inwc_GenerateSeed_IntelRD()to work around buggyRDSEEDby disabling it if it generates three identical 64 bit words consecutively;wolfssl/wolfcrypt/settings.h: ifDEBUG_WOLFSSL&& !WC_NO_VERBOSE_RNG, setWC_VERBOSE_RNG, and addWOLFSSL_NO_DEBUG_CERTSto allow inhibition ofWOLFSSL_DEBUG_CERTS.tested with
also, the new patch file tested good by customer.