Skip to content

API doc: ML-DSA, ML-KEM #9686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kojo1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

API doc: ML-DSA, ML-KEM #9686

kojo1 wants to merge 1 commit into from
+773 −1

Conversation

@kojo1
Copy link
Contributor

@kojo1 kojo1 commented Jan 20, 2026 •
edited
Loading

Description

Please describe the scope of the fix or feature addition.

Fixes zd#

Testing

How did you test?

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@kojo1 kojo1 requested a review from anhu January 20, 2026 07:28
kojiws
kojiws requested changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@kojiws kojiws left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the following comments.

kojiws
kojiws requested changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@kojiws kojiws left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check added comment?

kojiws
kojiws approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@kojiws kojiws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anhu
anhu requested changes Jan 21, 2026
View reviewed changes
Copy link
Member

@anhu anhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In each \brief section it says "This macro...."
While its true they are macros, I think it should say "This function..." or method or something else.

@kojo1
Copy link
Contributor Author

kojo1 commented Jan 21, 2026

In each \brief section it says "This macro...." ... should say "This function..."

On the same token, do you think it would be good to eliminate the wc_Dilithium_xxx lines?

This macro maps to wc_Dilithium_xxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anhu anhu anhu requested changes

@kojiws kojiws kojiws approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kojo1 @anhu @kojiws