ML-DSA fixes: small vfy key object, small SHA-3, fix test#10420
Open
SparkiDev wants to merge 1 commit intowolfSSL:masterfrom
Open
ML-DSA fixes: small vfy key object, small SHA-3, fix test#10420SparkiDev wants to merge 1 commit intowolfSSL:masterfrom
SparkiDev wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Only have the public key in the ML-DSA key object when verify-only. Be able to leave out SHA-3 APIs when only needing SHAKE. Fix ML-DSA testing to only have data for compiled in parameters.
Contributor
Author
|
Jenkins: retest this please |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10420
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
No new issues found in the changed files. ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Only have the public key in the ML-DSA key object when verify-only.
Be able to leave out SHA-3 APIs when only needing SHAKE.
Fix ML-DSA testing to only have data for compiled in parameters.
Testing
Various ML-DSA and SHA-3/SHAKE builds.