Align data in wolfboot test structs#364
Conversation
|
|
||
| /* wolfBoot signed header (RSA4096+SHA256, 1024 bytes) */ | ||
| static const uint8_t wolfboot_test_header[] = { | ||
| static const uint8_t wolfboot_test_header[] __attribute__((aligned(4))) = { |
There was a problem hiding this comment.
hmmm unfortunately this is clang/gcc specific and some target toolchains wont support it. I do want us to go to C11 but for now we are C99 :/
I would say we should probably add WH_ALIGN(_x) to wh_settings.h that can have per-architecture definitions. For now you can just toolchain detect clang and GCC. Believe we do this elsewhere. But in the future for other toolchains we can add support for those as they come online. Then this header will need to include settings.h which i'm sure will break everything else :(
There was a problem hiding this comment.
Updated to use XALIGNED(4) from wolfcrypt. Let me know if you'd rather create a separate macro in wolfhsm.
There was a problem hiding this comment.
thats fine for now. Will wait until the other fix clears CI then u can rebase this
Fixes this test failure on macos, adds
macos-latestto unit test runs in CI.