Add ret_size checking in server keystore#302
Open
padelsbach wants to merge 1 commit intowolfSSL:mainfrom
Open
Conversation
padelsbach
force-pushed
the
padelsbach/ret-size-server-keystore
branch
from
2e17ece to
cf37b07
Compare
bigbrett
requested changes
Mar 17, 2026
Comment on lines
+1682
to
+1684
| if (req_size < sizeof(req)) { | ||
| return WH_ERROR_BADARGS; | ||
| } |
Contributor
There was a problem hiding this comment.
These early returns cause the serialization of the response to be skipped. We need to ensure the response contains the appropriate error code and serialize it back to the caller. Otherwise we send a stale buffer in the calling context.
Contributor
There was a problem hiding this comment.
Note these layer-specific request processing functions are not meant to be called directly but only as part of the request processing pipeline internal by wh_Server_HandleRequestMessage()
Contributor
Author
There was a problem hiding this comment.
Good point. There's a bit more reworked error checking now.
padelsbach
force-pushed
the
padelsbach/ret-size-server-keystore
branch
from
cf37b07 to
48cdcea
Compare
padelsbach
force-pushed
the
padelsbach/ret-size-server-keystore
branch
from
48cdcea to
072967e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes finding 125