Skip to content

[boards] Fix off-by-one in SysTick cyclesPerTick #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[boards] Fix off-by-one in SysTick cyclesPerTick #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion boards/pic32cz_curiosity_ultra/board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ whal_Timer g_whalTimer = {
.driver = WHAL_CORTEX_M7_SYSTICK_DRIVER,

.cfg = &(whal_SysTick_Cfg) {
.cyclesPerTick = 300000000 / 1000,
.cyclesPerTick = (300000000 / 1000) - 1, /* SysTick reloads every LOAD+1 cycles */
.clkSrc = WHAL_SYSTICK_CLKSRC_SYSCLK,
.tickInt = WHAL_SYSTICK_TICKINT_ENABLED,
},
Expand Down
2 changes: 1 addition & 1 deletion boards/stm32c031_nucleo/board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ whal_Timer g_whalTimer = {
.driver = WHAL_CORTEX_M0PLUS_SYSTICK_DRIVER,

.cfg = &(whal_SysTick_Cfg) {
.cyclesPerTick = 48000000 / 1000, /* 48 MHz / 1 kHz = 1 ms tick */
.cyclesPerTick = (48000000 / 1000) - 1, /* 48 MHz / 1 kHz = 1 ms tick (SysTick reloads every LOAD+1 cycles) */
.clkSrc = WHAL_SYSTICK_CLKSRC_SYSCLK,
.tickInt = WHAL_SYSTICK_TICKINT_ENABLED,
},
Expand Down
2 changes: 1 addition & 1 deletion boards/stm32f091rc_nucleo/board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ whal_Timer g_whalTimer = {
.driver = WHAL_CORTEX_M0_SYSTICK_DRIVER,

.cfg = &(whal_SysTick_Cfg) {
.cyclesPerTick = 48000000 / 1000,
.cyclesPerTick = (48000000 / 1000) - 1, /* SysTick reloads every LOAD+1 cycles */
.clkSrc = WHAL_SYSTICK_CLKSRC_SYSCLK,
.tickInt = WHAL_SYSTICK_TICKINT_ENABLED,
},
Expand Down
2 changes: 1 addition & 1 deletion boards/stm32f302r8_nucleo/board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ whal_Timer g_whalTimer = {
.driver = WHAL_CORTEX_M4_SYSTICK_DRIVER,

.cfg = &(whal_SysTick_Cfg) {
.cyclesPerTick = 48000000 / 1000,
.cyclesPerTick = (48000000 / 1000) - 1, /* SysTick reloads every LOAD+1 cycles */
.clkSrc = WHAL_SYSTICK_CLKSRC_SYSCLK,
.tickInt = WHAL_SYSTICK_TICKINT_ENABLED,
},
Expand Down
2 changes: 1 addition & 1 deletion boards/stm32f411_blackpill/board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ whal_Timer g_whalTimer = {
.driver = WHAL_CORTEX_M4_SYSTICK_DRIVER,

.cfg = &(whal_SysTick_Cfg) {
.cyclesPerTick = 100000000 / 1000, /* 100 MHz / 1 kHz = 1 ms tick */
.cyclesPerTick = (100000000 / 1000) - 1, /* 100 MHz / 1 kHz = 1 ms tick (SysTick reloads every LOAD+1 cycles) */
.clkSrc = WHAL_SYSTICK_CLKSRC_SYSCLK,
.tickInt = WHAL_SYSTICK_TICKINT_ENABLED,
},
Expand Down
2 changes: 1 addition & 1 deletion boards/stm32h563zi_nucleo/board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ whal_Timer g_whalTimer = {
.driver = WHAL_CORTEX_M33_SYSTICK_DRIVER,

.cfg = &(whal_SysTick_Cfg) {
.cyclesPerTick = 168000000 / 1000, /* 168 MHz / 1 kHz = 1 ms tick */
.cyclesPerTick = (168000000 / 1000) - 1, /* 168 MHz / 1 kHz = 1 ms tick (SysTick reloads every LOAD+1 cycles) */
.clkSrc = WHAL_SYSTICK_CLKSRC_SYSCLK,
.tickInt = WHAL_SYSTICK_TICKINT_ENABLED,
},
Expand Down
2 changes: 1 addition & 1 deletion boards/stm32l152re_nucleo/board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ whal_Timer g_whalTimer = {
.driver = WHAL_CORTEX_M3_SYSTICK_DRIVER,

.cfg = &(whal_SysTick_Cfg) {
.cyclesPerTick = 32000000 / 1000,
.cyclesPerTick = (32000000 / 1000) - 1, /* SysTick reloads every LOAD+1 cycles */
.clkSrc = WHAL_SYSTICK_CLKSRC_SYSCLK,
.tickInt = WHAL_SYSTICK_TICKINT_ENABLED,
},
Expand Down
2 changes: 1 addition & 1 deletion boards/stm32n657a0_nucleo/board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ whal_Timer g_whalTimer = {
.driver = WHAL_CORTEX_M55_SYSTICK_DRIVER,

.cfg = &(whal_SysTick_Cfg) {
.cyclesPerTick = 64000000 / 1000, /* 64 MHz / 1 kHz = 1 ms tick */
.cyclesPerTick = (64000000 / 1000) - 1, /* 64 MHz / 1 kHz = 1 ms tick (SysTick reloads every LOAD+1 cycles) */
.clkSrc = WHAL_SYSTICK_CLKSRC_SYSCLK,
.tickInt = WHAL_SYSTICK_TICKINT_ENABLED,
},
Expand Down
2 changes: 1 addition & 1 deletion boards/stm32wb55xx_nucleo/board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ whal_Timer g_whalTimer = {
.driver = WHAL_CORTEX_M4_SYSTICK_DRIVER,

.cfg = &(whal_SysTick_Cfg) {
.cyclesPerTick = 64000000 / 1000,
.cyclesPerTick = (64000000 / 1000) - 1, /* SysTick reloads every LOAD+1 cycles */
.clkSrc = WHAL_SYSTICK_CLKSRC_SYSCLK,
.tickInt = WHAL_SYSTICK_TICKINT_ENABLED,
},
Expand Down
2 changes: 1 addition & 1 deletion boards/stm32wba55cg_nucleo/board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ whal_Timer g_whalTimer = {
.driver = WHAL_CORTEX_M33_SYSTICK_DRIVER,

.cfg = &(whal_SysTick_Cfg) {
.cyclesPerTick = 100000000 / 1000,
.cyclesPerTick = (100000000 / 1000) - 1, /* SysTick reloads every LOAD+1 cycles */
.clkSrc = WHAL_SYSTICK_CLKSRC_SYSCLK,
.tickInt = WHAL_SYSTICK_TICKINT_ENABLED,
},
Expand Down