Skip to content

Conversation

@benfenton
Copy link
Contributor

...jects

I created a new partial folder called "users" with a "_my_projects.scss" file in it.

Some questions:

  1. is "active"/"inactive" too general of a class name for such a specific style?
  2. did i organize the sass correctly?
  3. is it okay to user a ternary operator to set a class? I checked ng-class and that didn't seem appropriate for what we are doing here.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be ng-class = "{'inactive': !project.data.active}" You shouldn't use bindings inside class attribute; you must use ng-class attribute for dynamic things.

Check the angular docs for ng-class examples/explanation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants