Skip to content

fix(Fix_unreachable_netservices_v2): v16 compatibility fixes#5590

Open
Joeboyc2 wants to merge 1 commit intowled:mainfrom
Joeboyc2:fix/fix-unreachable-netservices-v16-compat-v2
Open

fix(Fix_unreachable_netservices_v2): v16 compatibility fixes#5590
Joeboyc2 wants to merge 1 commit intowled:mainfrom
Joeboyc2:fix/fix-unreachable-netservices-v16-compat-v2

Conversation

@Joeboyc2
Copy link
Copy Markdown
Contributor

@Joeboyc2 Joeboyc2 commented May 10, 2026

Summary

Two issues prevent Fix_unreachable_netservices_v2 from building under WLED v16:

  • Missing libArchive: false in library.json — the v16 build system requires "build": {"libArchive": false} in every usermod's library.json. Without it the build fails immediately with ERROR: libArchive=false is missing on usermod(s).

  • serializeConfig() no longer has a no-argument overload — v16 changed serializeConfig() to require a JsonObject parameter. The correct no-argument replacement for saving config to the filesystem is serializeConfigToFS().

Test plan

  • Fix_unreachable_netservices_v2 compiles cleanly in an ESP8266 build environment with both fixes applied
  • Verified serializeConfigToFS() is the correct equivalent — it allocates the JSON document internally and calls serializeConfig(root) + writes to LittleFS

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where network service configuration updates were not being properly persisted to storage.
  • Chores

    • Updated library build configuration settings.

Review Change Stack

Two issues prevent this usermod from building under v16:

1. library.json is missing "build": {"libArchive": false}, causing the
   build system to reject it with an error before compilation begins.

2. serializeConfig() no longer has a no-argument overload in v16; the
   correct replacement is serializeConfigToFS() which creates the JSON
   document internally and writes to the filesystem.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ccdd8ff5-ac87-42d1-857e-1f0d786c3a4e

📥 Commits

Reviewing files that changed from the base of the PR and between 37623ed and aba977b.

📒 Files selected for processing (2)
  • usermods/Fix_unreachable_netservices_v2/library.json
  • usermods/Fix_unreachable_netservices_v2/usermod_Fix_unreachable_netservices.cpp

Walkthrough

This PR fixes the FixUnreachableNetServices usermod by ensuring periodic configuration updates are persisted to the filesystem instead of kept in memory. The library manifest is also updated to control build archiving behavior.

Changes

Fix unreachable netservices v2

Layer / File(s) Summary
Build Configuration
usermods/Fix_unreachable_netservices_v2/library.json
Library manifest adds build.libArchive: false to control archiving behavior during the build process.
Runtime Config Persistence Fix
usermods/Fix_unreachable_netservices_v2/usermod_Fix_unreachable_netservices.cpp
Config update handler switches from serializeConfig() to serializeConfigToFS() to persist settings to filesystem during periodic updates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: v16 compatibility fixes for the Fix_unreachable_netservices_v2 usermod.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@softhack007 softhack007 added the AI Partly generated by an AI. Make sure that the contributor fully understands the code! label May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Partly generated by an AI. Make sure that the contributor fully understands the code!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants