-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Spinning Wheel FX in the user_fx usermod #5293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BobLoeffler68
wants to merge
8
commits into
wled:main
Choose a base branch
from
BobLoeffler68:pr-spinningwheel-user-fx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+254
−0
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f2f25f2
Added the Spinning Wheel effect into the user_fx usermod
BobLoeffler68 de79954
Fixed a few issues that coderabbit mentioned
BobLoeffler68 6376750
Fixed integer overflow when storing color scale in aux1. And added a …
BobLoeffler68 a707b39
Additions/changes:
BobLoeffler68 4b81ea8
One minor fix for the spinner colors
BobLoeffler68 ccff1b5
Changed the two analogRead() to hw_random16()
BobLoeffler68 0f5469a
Changes from SEGLEN to vstripLen suggested by coderabbitai, but it's …
BobLoeffler68 0833dac
Rolled back changes from vstripLen to SEGLEN as that is what works co…
BobLoeffler68 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.