[Incubator.Slider] Add useRelativeDrag prop for relative drag mode#3968
Open
[Incubator.Slider] Add useRelativeDrag prop for relative drag mode#3968
Conversation
Added .hitSlop() to the RNGH Gesture.Pan() on the thumb so the gesture handler natively recognizes touches in the expanded hit area on Android. Also added hitSlop to the Pan gesture mock in jest setup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a container-level RNGH Gesture.Pan() that moves the thumb relative to its current position when useRelativeDrag is true. The thumb gets pointerEvents="none" so the container gesture takes over, and isActive is passed to keep the thumb's active styling in sync. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
Contributor
Author
How to reproduceDrop this into import React, {useState} from 'react';
import {Platform} from 'react-native';
import {View, Text, Switch, Incubator} from 'react-native-ui-lib';
const TAG = `[Slider-${Platform.OS}]`;
export default function PlaygroundScreen() {
const [disabled, setDisabled] = useState(false);
return (
<View flex padding-20>
<Text text60 marginB-20>
Slider Debug ({Platform.OS})
</Text>
<View row centerV marginB-20>
<Text text70 marginR-10>
Disabled
</Text>
<Switch value={disabled} onValueChange={setDisabled}/>
</View>
<Text text70 marginB-10>
Incubator.Slider (normal)
</Text>
<View
style={{width: '100%', height: 60, justifyContent: 'center'}}
onTouchStart={() => console.log(`${TAG} - PARENT onTouchStart`)}
onTouchEnd={() => console.log(`${TAG} - PARENT onTouchEnd`)}
>
<Incubator.Slider
value={30}
minimumValue={0}
maximumValue={100}
disabled={disabled}
onSeekStart={() => console.log(`${TAG} - Incubator.Slider - onSeekStart`)}
onSeekEnd={() => console.log(`${TAG} - Incubator.Slider - onSeekEnd`)}
onValueChange={(v: number) => console.log(`${TAG} - Incubator.Slider - onValueChange: ${v.toFixed(1)}`)}
/>
</View>
<Text text70 marginT-40 marginB-10>
Incubator.Slider (useRelativeDrag)
</Text>
<View
style={{width: '100%', height: 60, justifyContent: 'center'}}
onTouchStart={() => console.log(`${TAG} - PARENT onTouchStart (relative)`)}
onTouchEnd={() => console.log(`${TAG} - PARENT onTouchEnd (relative)`)}
>
<Incubator.Slider
value={30}
minimumValue={0}
maximumValue={100}
disabled={disabled}
useRelativeDrag
onSeekStart={() => console.log(`${TAG} - Incubator.Slider (relative) - onSeekStart`)}
onSeekEnd={() => console.log(`${TAG} - Incubator.Slider (relative) - onSeekEnd`)}
onValueChange={(v: number) => console.log(`${TAG} - Incubator.Slider (relative) - onValueChange: ${v.toFixed(1)}`)}
/>
</View>
</View>
);
}What to test
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
useRelativeDragsupport toIncubator.Slider.Uses a container-level RNGH
Gesture.Pan()withpointerEvents="none"on the thumb — dragging anywhere on the slider moves the thumb relative to its current position instead of snapping to the touch point. Designed for single-thumb mode.Changelog
Incubator.Slider - Added
useRelativeDragprop for relative drag mode.Additional info